Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create task cleanups for scale down at request update time #1811

Merged
merged 6 commits into from Jul 9, 2018

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Jun 19, 2018

We can run into a certain sate where consistent continuous instance numbers are not kept. If a cleanup is created between a request scaling down and the scheduler processing the pending request update, this can occur. This PR creates the task cleanups for the specific instances that need to be cleaned up at request update time to avoid that possible window.

@ssalinas ssalinas added the hs_staging label Jun 20, 2018
@@ -149,6 +151,24 @@ private void submitRequest(SingularityRequest request, Optional<SingularityReque
requestState = oldRequestWithState.get().getState();
}

if (oldRequest.isPresent() && oldRequest.get().getInstancesSafe() < request.getInstancesSafe()) {

This comment has been minimized.

@baconmania

baconmania Jun 20, 2018
Contributor

I think we want to swap the operands on this comparison.

This comment has been minimized.

@ssalinas

ssalinas Jun 20, 2018
Author Member

We do indeed, hadn’t actually gotten a chance to finish unit test and testing in staging in this one yet

ssalinas added 2 commits Jun 21, 2018
@ssalinas ssalinas added the hs_qa label Jun 21, 2018
ssalinas added 2 commits Jun 21, 2018
@ssalinas
Copy link
Member Author

@ssalinas ssalinas commented Jun 21, 2018

PR all fixed up and working in QA

@pschoenfelder
Copy link
Contributor

@pschoenfelder pschoenfelder commented Jul 3, 2018

🚢

@ssalinas ssalinas added the hs_stable label Jul 3, 2018
@ssalinas ssalinas added this to the 0.21.0 milestone Jul 9, 2018
@ssalinas ssalinas merged commit 6179eb1 into master Jul 9, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the missing_instance_no branch Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.