Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate task cleanups for scale down at request update time #1811
Conversation
ssalinas
added some commits
Jun 19, 2018
ssalinas
added
the
hs_staging
label
Jun 20, 2018
ssalinas
added some commits
Jun 21, 2018
ssalinas
added
the
hs_qa
label
Jun 21, 2018
ssalinas
added some commits
Jun 21, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
PR all fixed up and working in QA |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
|
ssalinas
added
the
hs_stable
label
Jul 3, 2018
ssalinas
added this to the 0.21.0 milestone
Jul 9, 2018
ssalinas
merged commit 6179eb1
into
master
Jul 9, 2018
ssalinas
deleted the
missing_instance_no
branch
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ssalinas commentedJun 19, 2018
We can run into a certain sate where consistent continuous instance numbers are not kept. If a cleanup is created between a request scaling down and the scheduler processing the pending request update, this can occur. This PR creates the task cleanups for the specific instances that need to be cleaned up at request update time to avoid that possible window.