Create task cleanups for scale down at request update time #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconmania
reviewed
Jun 20, 2018
| @@ -149,6 +151,24 @@ private void submitRequest(SingularityRequest request, Optional<SingularityReque | |||
| requestState = oldRequestWithState.get().getState(); | |||
| } | |||
|
|
|||
| if (oldRequest.isPresent() && oldRequest.get().getInstancesSafe() < request.getInstancesSafe()) { | |||
There was a problem hiding this comment.
I think we want to swap the operands on this comparison.
There was a problem hiding this comment.
We do indeed, hadn’t actually gotten a chance to finish unit test and testing in staging in this one yet
|
PR all fixed up and working in QA |
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can run into a certain sate where consistent continuous instance numbers are not kept. If a cleanup is created between a request scaling down and the scheduler processing the pending request update, this can occur. This PR creates the task cleanups for the specific instances that need to be cleaned up at request update time to avoid that possible window.