Skip to content

Create task cleanups for scale down at request update time - #1811

Merged
ssalinas merged 6 commits into
masterfrom
missing_instance_no
Jul 9, 2018
Merged

ssalinas merged 6 commits into
masterfrom
missing_instance_no

Conversation

@ssalinas

Copy link
Copy Markdown
Contributor

We can run into a certain sate where consistent continuous instance numbers are not kept. If a cleanup is created between a request scaling down and the scheduler processing the pending request update, this can occur. This PR creates the task cleanups for the specific instances that need to be cleaned up at request update time to avoid that possible window.

requestState = oldRequestWithState.get().getState();
}

if (oldRequest.isPresent() && oldRequest.get().getInstancesSafe() < request.getInstancesSafe()) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to swap the operands on this comparison.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do indeed, hadn’t actually gotten a chance to finish unit test and testing in staging in this one yet

@ssalinas ssalinas added the hs_qa label Jun 21, 2018
@ssalinas

Copy link
Copy Markdown
Contributor Author

PR all fixed up and working in QA

@pschoenfelder

Copy link
Copy Markdown
Contributor

🚢

@ssalinas ssalinas added this to the 0.21.0 milestone Jul 9, 2018
@ssalinas
ssalinas merged commit 6179eb1 into master Jul 9, 2018
@ssalinas
ssalinas deleted the missing_instance_no branch July 9, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants