New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent new host overloading #1822

Merged
merged 29 commits into from Aug 16, 2018

Conversation

Projects
None yet
3 participants
@pschoenfelder
Contributor

pschoenfelder commented Jul 17, 2018

No description provided.

@pschoenfelder pschoenfelder requested a review from ssalinas Jul 17, 2018

@ssalinas

I think the overall strategy of refreshing metrics in the offer scoring for things is good. Definitely want to make sure we only do it when metrics are too old (or maybe also after some number of additional tasks/percent of resources allocated since last metric?) and that we determine what kind of impact this has on scheduling speed

@ssalinas

Added a few comments on the async bits. The main point I'm not sure on is whether or not we are kicking off metric collect for use in a future offer scoring run, or gathering metrics synchronously for use in the current offer scoring run. I could see the first being faster for scoring, but we need to be careful that we aren't kicking off a bunch in a row for the same slave (i.e. because the first call hasn't finished yet). The second is more reliable in terms of making sure we have the most up to date metrics, but is slower since we have to wait for them

pschoenfelder added some commits Jul 31, 2018

pschoenfelder and others added some commits Aug 1, 2018

@ssalinas ssalinas changed the title from WIP: Prevent new host overloading to Prevent new host overloading Aug 6, 2018

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Aug 6, 2018

Member

🚢

Member

ssalinas commented Aug 6, 2018

🚢

1 similar comment
@pschoenfelder

This comment has been minimized.

Show comment
Hide comment
@pschoenfelder

pschoenfelder Aug 6, 2018

Contributor

🚢

Contributor

pschoenfelder commented Aug 6, 2018

🚢

@ssalinas ssalinas added the hs_stable label Aug 6, 2018

pschoenfelder added some commits Aug 6, 2018

pschoenfelder added some commits Aug 7, 2018

ssalinas and others added some commits Aug 8, 2018

Merge pull request #1828 from HubSpot/skip_host
 Skip hosts which do not have valid metrics during offer processing

@ssalinas ssalinas added this to the 0.21.0 milestone Aug 9, 2018

@baconmania

This comment has been minimized.

Show comment
Hide comment
@baconmania

baconmania Aug 9, 2018

Contributor

🚢

Contributor

baconmania commented Aug 9, 2018

🚢

@ssalinas ssalinas merged commit 29c7199 into master Aug 16, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@ssalinas ssalinas deleted the new-host-overloading branch Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment