Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprioritize STARTUP-type pending requests. #1825

merged 5 commits into from Aug 9, 2018


Copy link

No description provided.

@@ -239,6 +239,16 @@ public SingularityCreateResult finish(SingularityRequest request, long timestamp
public SingularityCreateResult addToPendingQueue(SingularityPendingRequest pendingRequest) {
SingularityCreateResult result = create(getPendingPath(pendingRequest), pendingRequest, pendingRequestTranscoder);

if (result == SingularityCreateResult.EXISTED) {
SingularityPendingRequest existingPendingRequest = getPendingRequest(pendingRequest.getRequestId(), pendingRequest.getDeployId()).get();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the scheduler poller could run between the create and this get, we can't assume that this optional will be present. Should probably add the isPresent check

Copy link

ssalinas commented Aug 6, 2018


@ssalinas ssalinas added this to the 0.21.0 milestone Aug 9, 2018
@ssalinas ssalinas merged commit 1fb665e into master Aug 9, 2018
@ssalinas ssalinas deleted the deprioritize-STARTUP-pending-requests branch August 9, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants