Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprioritize STARTUP-type pending requests. #1825

Merged
merged 5 commits into from Aug 9, 2018

Conversation

@baconmania
Copy link
Contributor

@baconmania baconmania commented Jul 30, 2018

No description provided.

@@ -239,6 +239,16 @@ public SingularityCreateResult finish(SingularityRequest request, long timestamp
public SingularityCreateResult addToPendingQueue(SingularityPendingRequest pendingRequest) {
SingularityCreateResult result = create(getPendingPath(pendingRequest), pendingRequest, pendingRequestTranscoder);

if (result == SingularityCreateResult.EXISTED) {
SingularityPendingRequest existingPendingRequest = getPendingRequest(pendingRequest.getRequestId(), pendingRequest.getDeployId()).get();

This comment has been minimized.

@ssalinas

ssalinas Jul 31, 2018
Member

Since the scheduler poller could run between the create and this get, we can't assume that this optional will be present. Should probably add the isPresent check

@baconmania baconmania added the hs_qa label Aug 1, 2018
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Aug 6, 2018

🚢

@ssalinas ssalinas added the hs_stable label Aug 6, 2018
@ssalinas ssalinas added this to the 0.21.0 milestone Aug 9, 2018
@ssalinas ssalinas merged commit 1fb665e into master Aug 9, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
@ssalinas ssalinas deleted the deprioritize-STARTUP-pending-requests branch Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.