Prepare a StreamingOutput response when serving file downloads. #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconmania
commented
Aug 8, 2018
| .get() | ||
| .getResponseBodyAsStream(); | ||
| PerRequestConfig unlimitedTimeout = new PerRequestConfig(); | ||
| unlimitedTimeout.setRequestTimeoutInMs(-1); |
There was a problem hiding this comment.
The default 60 second timeout on our AsyncHttpClient is insufficient for large file downloads.
baconmania
commented
Aug 8, 2018
| @@ -656,4 +668,56 @@ public Response downloadFileOverProxy( | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| private static class NingOutputToJaxRsStreamingOutputWrapper implements AsyncHandler<Void>, StreamingOutput { | |||
There was a problem hiding this comment.
Fully open to suggestions on a better name for this, heh.
baconmania
commented
Aug 8, 2018
| if (wrappedOutputStream == null) { | ||
| wrappedOutputStream = output; | ||
| try { | ||
| requestBuilder.execute(this).get(); |
There was a problem hiding this comment.
We need to do it this way because the OutputStream doesn't become available to us until Jersey actually calls write() on this implementation. The alternative would be to begin the proxied request before waiting for Jersey, in which case we'd be back to buffering a potentially large response in memory.
The get() here on the Future is also necessary because Jersey expects write() to be a blocking call, and closes the provided OutputStream after this method returns.
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares a 4k buffer and pipes the HTTP response InputStream to a jax-rs compatible StreamingOutput object.