Make requestUtilization map thread safe. #1850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The
requestUtilizations
map is iterated over when it gets loaded into a newHashMap
here:Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityLeaderCache.java
Line 460 in 2c77825
Because
requestUtilizations
wasn't previously threadsafe, we'd get occasionalConcurrentModificationException
s here.