New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make requestUtilization map thread safe. #1850

Merged
merged 2 commits into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@baconmania
Contributor

baconmania commented Sep 13, 2018

The requestUtilizations map is iterated over when it gets loaded into a new HashMap here:

Because requestUtilizations wasn't previously threadsafe, we'd get occasional ConcurrentModificationExceptions here.

baconmania added some commits Sep 13, 2018

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Sep 14, 2018

Member

🚢

Member

ssalinas commented Sep 14, 2018

🚢

@ssalinas ssalinas merged commit b8c5c42 into master Sep 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the threadsafe-utilization-map branch Sep 26, 2018

@ssalinas ssalinas added this to the 0.21.0 milestone Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment