Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a lock & a timeout when checking whether an upload target file is open. #1852

Merged
merged 4 commits into from Sep 26, 2018

Conversation

@baconmania
Copy link
Contributor

@baconmania baconmania commented Sep 19, 2018

No description provided.

@@ -68,6 +72,8 @@
this.logIdentifier = String.format("[%s]", metadataPath.getFileName());
this.configuration = configuration;
this.exceptionNotifier = exceptionNotifier;

this.checkFileOpenLock = new ReentrantLock();

This comment has been minimized.

@ssalinas

ssalinas Sep 19, 2018
Member

Just checking, is this class always a singleton? Want to make sure we aren't just creating multiple locks. I had thought the singleton was the uploader driver, not the uploader

This comment has been minimized.

@baconmania

baconmania Sep 19, 2018
Author Contributor

Good catch. Fixed.

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Sep 20, 2018

🚢

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Sep 21, 2018

🚢

@ssalinas ssalinas merged commit 3eca071 into master Sep 26, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
@ssalinas ssalinas deleted the check-file-open-timeout branch Sep 26, 2018
@ssalinas ssalinas added this to the 0.21.0 milestone Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.