Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SingularityUI snappier #1860

Merged
merged 18 commits into from Oct 2, 2018
Merged

Make SingularityUI snappier #1860

merged 18 commits into from Oct 2, 2018

Conversation

ssalinas
Copy link
Member

and update node/npm...
and remove the vulnerable dependencies...
and...
and...

WIP

cc @kwm4385

@ssalinas
Copy link
Member Author

ssalinas commented Oct 1, 2018

Summary so far:

  • Address most of the vulnerable dep changes. The bootstrap one requires an upgrade to bootstrap 4
  • Uses the request ids list (from global search) for the requests table until the regular request json finishes loading, will allow the user to start searching/filtering earlier.
  • Global search just uses request ids rather than requesting the full json (which was previously done on every page because of this)
  • remove a duplicate ravenjs dep, we are including sentry in other ways
  • remove select2 dep, unused that I could find
  • update node sass so we can run on newer node/npm

before:
screen shot 2018-10-01 at 11 16 36 am
after:
screen shot 2018-10-01 at 11 16 15 am

@ssalinas ssalinas added the hs_qa label Oct 1, 2018
@kwm4385
Copy link
Contributor

kwm4385 commented Oct 1, 2018

Code looks fine besides a few style nits, but I'm not worried about that since we don't have up to date linting on here (A project for another time perhaps).

Are we still sticking with the requests page as the index?

@ssalinas
Copy link
Member Author

ssalinas commented Oct 1, 2018

Yeah, seemed to be the consensus that requests was the most useful page to land on. The dashboard attempted to be more personalized, but most folks just went right to requests to filter for the thing they were looking for anyways

@kwm4385
Copy link
Contributor

kwm4385 commented Oct 1, 2018

Gotcha, and now that its fast enough we don't have the need to make the global search the landing.

🚢

@ssalinas ssalinas added this to the 0.22.0 milestone Oct 1, 2018
@ssalinas ssalinas merged commit 11a533e into master Oct 2, 2018
@ssalinas ssalinas deleted the y_u_load_so_slow branch October 2, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants