Don't count pending tasks limited by instance count in task lag #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imited by instance count
baconmania
reviewed
Nov 16, 2018
SingularityService/src/main/java/com/hubspot/singularity/data/StateManager.java
Outdated
Show resolved
Hide resolved
baconmania
reviewed
Nov 16, 2018
SingularityService/src/main/java/com/hubspot/singularity/data/StateManager.java
Outdated
Show resolved
Hide resolved
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you submit pending tasks in quick succession on an on demand request that has an instance count limit, you can end up with tasks that will wait for the first to complete before launching. We shouldn't page for task lag in these cases. I've separated the late tasks on on-demand requests from the rest of the late tasks. This allows us to get better metrics on task lag and improve our alerts.