Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch more SQL exceptions in persister queries #2038

merged 2 commits into from Nov 19, 2019


Copy link

@ssalinas ssalinas commented Nov 12, 2019

If Singulairty was interrupted between the history persist and the removal from zk, subsequent attempts to run the persister would fail out on unique key errors. request and deploy history can easily be updated on duplicate primary key instead. The task history persister does not have this problem because it checks in a different way

@ssalinas ssalinas changed the title ON DUPLICATE KEY UPDATE for persister queries Catch more SQL exceptions in persister queries Nov 12, 2019
Copy link


@ssalinas ssalinas merged commit 3ba1632 into master Nov 19, 2019
@ssalinas ssalinas deleted the persister_fixes branch November 19, 2019 22:11
@ssalinas ssalinas added this to the 1.1.0 milestone Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants