Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version SingularityUI assets #2058

Merged
merged 3 commits into from Jan 22, 2020
Merged

Version SingularityUI assets #2058

merged 3 commits into from Jan 22, 2020

Conversation

ssalinas
Copy link
Member

This has been a problem for a while, that updates to the UI would take a hard refresh to load. We got around this internally by serving assets direct from nginx with slightly different structure and cache headers. However, this solves it so that things work direct from SingularityService.

gul-rev will add assets with a hash in their path, also templating that into the index file. These can essentially be cached forever since they will change when the UI code changes. Swagger ui assets are also now served direct from the backend so all assets are contained in SingularityService

/fixes #1641

@pschoenfelder
Copy link
Contributor

🚢

@ssalinas ssalinas merged commit ff20b0c into master Jan 22, 2020
@ssalinas ssalinas deleted the fix_asset_caching branch January 22, 2020 13:45
@ssalinas ssalinas added this to the 1.2.0 milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web interface JS caches forever (or just too long)
2 participants