Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not retry ON_DEMAND tasks which were killed by user request. #2059

merged 5 commits into from Jan 28, 2020


Copy link

No description provided.

return false; // don't retry one-off launches of on-demand jobs if they were killed by the user

if (task.get().getTaskRequest().getPendingTask().getPendingTaskId().getPendingType() == PendingType.IMMEDIATE
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, can we do this check first for efficiency since it doesn't require the task history lookup?

Copy link
Contributor Author

Tested live successfully.

Copy link


@WH77 WH77 added the hs_stable label Jan 24, 2020
@ssalinas ssalinas merged commit d88aa81 into master Jan 28, 2020
@ssalinas ssalinas deleted the do-not-retry-killed-ON_DEMANDs branch January 28, 2020 02:02
@ssalinas ssalinas added this to the 1.2.0 milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants