Conversation
Contributor
|
when you have a chance, can you rebase? those first 3 commits shouldn't be in the PR |
Contributor
Author
|
@tpetr merged master in and removed that comment, diff is now just the appropriate commits |
Contributor
There was a problem hiding this comment.
consider Optional<Boolean> for backwards compatibility
Contributor
Author
|
@tpetr made that boolean optional, and also added a constructor that matched the previous version, marked as deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tpetr @wsorenson