Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesos 0.23.0 #657

Merged
merged 21 commits into from Oct 7, 2015
Merged

Mesos 0.23.0 #657

merged 21 commits into from Oct 7, 2015

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Aug 17, 2015

@tpetr @wsorenson

@tpetr
Copy link
Member

@tpetr tpetr commented Aug 18, 2015

when you have a chance, can you rebase? those first 3 commits shouldn't be in the PR

Loading

@@ -35,8 +35,10 @@
<basepom.release.profiles>oss-release,build-swagger-documentation</basepom.release.profiles>

<baragon.version>0.1.4</baragon.version>
<mesos.docker.tag>0.21.1-1.1.ubuntu1404</mesos.docker.tag> <!-- 0.21.0-1.0.ubuntu1404 is missing for mesos-slave -->
<mesos.docker.tag>0.23.0-1.0.ubuntu1404</mesos.docker.tag> <!-- 0.21.0-1.0.ubuntu1404 is missing for mesos-slave -->
Copy link
Member

@tpetr tpetr Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment unnecessary here

Loading

@ssalinas
Copy link
Member Author

@ssalinas ssalinas commented Aug 18, 2015

@tpetr merged master in and removed that comment, diff is now just the appropriate commits

Loading


@JsonCreator
public SingularityDockerInfo(@JsonProperty("image") String image,
@JsonProperty("privileged") boolean privileged,
@JsonProperty("network") SingularityDockerNetworkType network,
@JsonProperty("portMappings") Optional<List<SingularityDockerPortMapping>> portMappings) {
@JsonProperty("portMappings") Optional<List<SingularityDockerPortMapping>> portMappings,
@JsonProperty("forcePullImage") boolean forcePullImage,
Copy link
Member

@tpetr tpetr Sep 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider Optional<Boolean> for backwards compatibility

Loading

@ssalinas
Copy link
Member Author

@ssalinas ssalinas commented Sep 22, 2015

@tpetr made that boolean optional, and also added a constructor that matched the previous version, marked as deprecated

Loading

@ssalinas ssalinas added the hs_qa label Sep 29, 2015
@tpetr tpetr added the hs_stable label Oct 6, 2015
@ssalinas ssalinas added this to the 0.4.5 milestone Oct 7, 2015
@tpetr tpetr merged commit b75a1e0 into master Oct 7, 2015
2 checks passed
Loading
@tpetr tpetr removed hs_qa labels Oct 7, 2015
@ssalinas ssalinas deleted the mesos_23 branch Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants