Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring the Network field should not be predicated on having port mappings configured #682

Merged
merged 1 commit into from Oct 13, 2015

Conversation

@stevenschlansker
Copy link
Contributor

@stevenschlansker stevenschlansker commented Sep 8, 2015

Imagine a "no network at all" network type, or a worker that does not expose any API but may connect outwardly.

@stevenschlansker stevenschlansker force-pushed the stevenschlansker:network-no-ports branch from 4d96888 to 590b13f Sep 9, 2015
@ssalinas ssalinas added the hs_staging label Sep 22, 2015
@ssalinas ssalinas added the hs_qa label Oct 8, 2015
@tpetr tpetr added the hs_stable label Oct 13, 2015
@tpetr tpetr added this to the 0.4.6 milestone Oct 13, 2015
@tpetr tpetr merged commit 590b13f into HubSpot:master Oct 13, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tpetr tpetr removed hs_qa labels Oct 13, 2015
@stevenschlansker stevenschlansker deleted the stevenschlansker:network-no-ports branch Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.