Show extra cmd line arguments and allow rerunning of tasks #708

Merged
merged 17 commits into from Oct 14, 2015

Conversation

Projects
None yet
3 participants
@kwm4385
Contributor

kwm4385 commented Sep 28, 2015

New UI features:

  • Show the command line arguments that were run on the task and deploy detail pages, under "Info" section.
  • Add a Rerun button (↺) in the task history table for on-demand tasks that will open the run now dialog with the cmd line arguments box prepopulated with what that task originally ran with.
  • In the dialog shown after clicking "Run Now" you can now use the up and down arrow keys to scroll though argument history for that request.

@kwm4385 kwm4385 added the hs_staging label Sep 28, 2015

@@ -12,3 +12,34 @@
<div class="vex-dialog-input">
<input id='filename' name="filename" type="text" class="vex-dialog-prompt-input" placeholder="e.g. service.log" value="">
</div>
+
+<script>

This comment has been minimized.

@benrlodge

benrlodge Sep 28, 2015

Contributor

i'm sure we can find a way to get this out of the markup.

@benrlodge

benrlodge Sep 28, 2015

Contributor

i'm sure we can find a way to get this out of the markup.

This comment has been minimized.

@kwm4385

kwm4385 Sep 28, 2015

Contributor

Yeah I'll do another pass through on this.

@kwm4385

kwm4385 Sep 28, 2015

Contributor

Yeah I'll do another pass through on this.

This comment has been minimized.

@benrlodge

benrlodge Sep 28, 2015

Contributor

give me a shout if you get stuck - there's a few different ways to use vex, some more shorthand than others (you can see different examples throughout singularity) and the vex docs obviously as well could be useful to read through http://github.hubspot.com/vex/

@benrlodge

benrlodge Sep 28, 2015

Contributor

give me a shout if you get stuck - there's a few different ways to use vex, some more shorthand than others (you can see different examples throughout singularity) and the vex docs obviously as well could be useful to read through http://github.hubspot.com/vex/

@@ -152,7 +157,16 @@ class Request extends Model
return false
else
- localStorage.setItem(@localStorageCommandLineInputKeyPrefix + @id, commandLineInput) if commandLineInput?
+ history = localStorage.getItem(@localStorageCommandLineInputKeyPrefix + @id)

This comment has been minimized.

@benrlodge

benrlodge Sep 28, 2015

Contributor

it would be nice if we could move all this local storage related stuff out to some utility file. it always bugged me that we already have all this vex stuff in a model file, maybe we can tackle that in another issue, but it would be nice if we could lean this out a bit.

@benrlodge

benrlodge Sep 28, 2015

Contributor

it would be nice if we could move all this local storage related stuff out to some utility file. it always bugged me that we already have all this vex stuff in a model file, maybe we can tackle that in another issue, but it would be nice if we could lean this out a bit.

This comment has been minimized.

@kwm4385

kwm4385 Sep 28, 2015

Contributor

I noticed that too. It would make sense move localstorage and vex interactions into utilities. We should probably make another issue though since it would add a lot of clutter.

@kwm4385

kwm4385 Sep 28, 2015

Contributor

I noticed that too. It would make sense move localstorage and vex interactions into utilities. We should probably make another issue though since it would add a lot of clutter.

kwm4385 added some commits Sep 28, 2015

@benrlodge

This comment has been minimized.

Show comment
Hide comment
@benrlodge

benrlodge Oct 1, 2015

Contributor

We should keep event handlers in the Views - looks like RequestView in this case (e.g. same as scaleRequest pauseRequest)

We should keep event handlers in the Views - looks like RequestView in this case (e.g. same as scaleRequest pauseRequest)

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Oct 2, 2015

Contributor

I don't think this will work in the view because the element that it needs to bind to doesn't exist until after the dialog is opened (hence why its in afterOpen). Is there another way we could handle this?

Contributor

kwm4385 replied Oct 2, 2015

I don't think this will work in the view because the element that it needs to bind to doesn't exist until after the dialog is opened (hence why its in afterOpen). Is there another way we could handle this?

This comment has been minimized.

Show comment
Hide comment
@benrlodge

benrlodge Oct 2, 2015

Contributor

ah sorry about that, didn't realize this was in the vex modal.

Contributor

benrlodge replied Oct 2, 2015

ah sorry about that, didn't realize this was in the vex modal.

@benrlodge

This comment has been minimized.

Show comment
Hide comment
@benrlodge

benrlodge Oct 1, 2015

Contributor

this stuff too

this stuff too

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Oct 13, 2015

Member

i'd like to roll the rerun button out, but I think we need more work on the argument history stuff. could we move those changes into a separate PR?

Member

tpetr commented Oct 13, 2015

i'd like to roll the rerun button out, but I think we need more work on the argument history stuff. could we move those changes into a separate PR?

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Oct 13, 2015

Contributor

Would disabling the history stuff (but still keeping the code in) be good enough to merge this and then start another PR?

Contributor

kwm4385 commented Oct 13, 2015

Would disabling the history stuff (but still keeping the code in) be good enough to merge this and then start another PR?

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Oct 14, 2015

Member

@kwm4385 yeah that should be OK

Member

tpetr commented Oct 14, 2015

@kwm4385 yeah that should be OK

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Oct 14, 2015

Contributor

@tpetr Good to go.

Contributor

kwm4385 commented Oct 14, 2015

@tpetr Good to go.

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Oct 14, 2015

Member

looks good, but task rerun dialog doesnt seem to work for me -- never gets past "waiting for task to launch"

Member

tpetr commented Oct 14, 2015

looks good, but task rerun dialog doesnt seem to work for me -- never gets past "waiting for task to launch"

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Oct 14, 2015

Member

^ we'll address the auto-tail issue in a different PR

Member

tpetr commented Oct 14, 2015

^ we'll address the auto-tail issue in a different PR

@tpetr tpetr added the hs_qa label Oct 14, 2015

@tpetr tpetr added this to the 0.4.6 milestone Oct 14, 2015

@tpetr tpetr added the hs_stable label Oct 14, 2015

tpetr added a commit that referenced this pull request Oct 14, 2015

Merge pull request #708 from HubSpot/show_extracmdargs
Show extra cmd line arguments and allow rerunning of tasks

@tpetr tpetr merged commit 1ef18f2 into master Oct 14, 2015

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ssalinas ssalinas deleted the show_extracmdargs branch Apr 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment