Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show extra cmd line arguments and allow rerunning of tasks #708

Merged
merged 17 commits into from
Oct 14, 2015
Merged

Show extra cmd line arguments and allow rerunning of tasks #708

merged 17 commits into from
Oct 14, 2015

Conversation

kwm4385
Copy link
Contributor

@kwm4385 kwm4385 commented Sep 28, 2015

New UI features:

  • Show the command line arguments that were run on the task and deploy detail pages, under "Info" section.
  • Add a Rerun button (↺) in the task history table for on-demand tasks that will open the run now dialog with the cmd line arguments box prepopulated with what that task originally ran with.
  • In the dialog shown after clicking "Run Now" you can now use the up and down arrow keys to scroll though argument history for that request.

benrlodge
benrlodge reviewed Sep 28, 2015
View reviewed changes
SingularityUI/app/templates/vex/requestRun.hbs
@@ -12,3 +12,34 @@
<div class="vex-dialog-input">
<input id='filename' name="filename" type="text" class="vex-dialog-prompt-input" placeholder="e.g. service.log" value="">
</div>

<script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm sure we can find a way to get this out of the markup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll do another pass through on this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give me a shout if you get stuck - there's a few different ways to use vex, some more shorthand than others (you can see different examples throughout singularity) and the vex docs obviously as well could be useful to read through http://github.hubspot.com/vex/

@tpetr
Copy link
Contributor

tpetr commented Oct 13, 2015

i'd like to roll the rerun button out, but I think we need more work on the argument history stuff. could we move those changes into a separate PR?

@kwm4385
Copy link
Contributor Author

kwm4385 commented Oct 13, 2015

Would disabling the history stuff (but still keeping the code in) be good enough to merge this and then start another PR?

@tpetr
Copy link
Contributor

tpetr commented Oct 14, 2015

@kwm4385 yeah that should be OK

@kwm4385
Copy link
Contributor Author

kwm4385 commented Oct 14, 2015

@tpetr Good to go.

@tpetr
Copy link
Contributor

tpetr commented Oct 14, 2015

looks good, but task rerun dialog doesnt seem to work for me -- never gets past "waiting for task to launch"

@tpetr
Copy link
Contributor

tpetr commented Oct 14, 2015

^ we'll address the auto-tail issue in a different PR

@tpetr tpetr added the hs_qa label Oct 14, 2015
@tpetr tpetr added this to the 0.4.6 milestone Oct 14, 2015
tpetr pushed a commit that referenced this pull request Oct 14, 2015
Merge pull request #708 from HubSpot/show_extracmdargs
1ef18f2 
Show extra cmd line arguments and allow rerunning of tasks
@tpetr tpetr merged commit 1ef18f2 into master Oct 14, 2015
@tpetr tpetr removed hs_qa labels Oct 14, 2015
This was referenced Oct 14, 2015
Closed
Closed
@ssalinas ssalinas deleted the show_extracmdargs branch April 5, 2016 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@kwm4385 @tpetr @benrlodge