Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give meaningful titles to all pages #713

Merged
merged 3 commits into from Oct 14, 2015
Merged

Give meaningful titles to all pages #713

merged 3 commits into from Oct 14, 2015

Conversation

@kwm4385
Copy link
Contributor

kwm4385 commented Oct 1, 2015

No description provided.

@@ -20,6 +20,8 @@ class DeployDetailController extends Controller
healthChecks: require '../templates/deployDetail/deployHealthChecks'

initialize: ({@requestId, @deployId}) ->
@title @deployId

This comment has been minimized.

Copy link
@tpetr

tpetr Oct 2, 2015

Member

I don't think the deploy ID is descriptive enough here -- something like "#{ @requestId } deploy #{ @deployId }" would make more sense

@kwm4385
Copy link
Contributor Author

kwm4385 commented Oct 5, 2015

👍

@tpetr tpetr force-pushed the page_titles branch from 7a51023 to 23c2a5a Oct 13, 2015
@tpetr tpetr force-pushed the page_titles branch from 23c2a5a to 6261919 Oct 14, 2015
@tpetr tpetr added the hs_staging label Oct 14, 2015
tpetr added a commit that referenced this pull request Oct 14, 2015
Give meaningful titles to all pages
@tpetr tpetr merged commit adb8bb3 into master Oct 14, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tpetr tpetr removed the hs_staging label Oct 14, 2015
@tpetr tpetr added this to the 0.4.6 milestone Oct 14, 2015
@ssalinas ssalinas deleted the page_titles branch Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.