Give meaningful titles to all pages #713

Merged
merged 3 commits into from Oct 14, 2015

Conversation

Projects
None yet
2 participants
@kwm4385
Contributor

kwm4385 commented Oct 1, 2015

No description provided.

@@ -20,6 +20,8 @@ class DeployDetailController extends Controller
healthChecks: require '../templates/deployDetail/deployHealthChecks'
initialize: ({@requestId, @deployId}) ->
+ @title @deployId

This comment has been minimized.

@tpetr

tpetr Oct 2, 2015

Member

I don't think the deploy ID is descriptive enough here -- something like "#{ @requestId } deploy #{ @deployId }" would make more sense

@tpetr

tpetr Oct 2, 2015

Member

I don't think the deploy ID is descriptive enough here -- something like "#{ @requestId } deploy #{ @deployId }" would make more sense

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Oct 5, 2015

Contributor

👍

Contributor

kwm4385 commented Oct 5, 2015

👍

@tpetr tpetr added the hs_staging label Oct 14, 2015

tpetr added a commit that referenced this pull request Oct 14, 2015

Merge pull request #713 from HubSpot/page_titles
Give meaningful titles to all pages

@tpetr tpetr merged commit adb8bb3 into master Oct 14, 2015

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tpetr tpetr removed the hs_staging label Oct 14, 2015

@tpetr tpetr added this to the 0.4.6 milestone Oct 14, 2015

@ssalinas ssalinas deleted the page_titles branch Apr 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment