Skip to content

Task alerts - #721

Merged
tpetr merged 18 commits into
masterfrom
task_alerts
Oct 15, 2015
Merged

Task alerts#721
tpetr merged 18 commits into
masterfrom
task_alerts

Conversation

@kwm4385

@kwm4385 kwm4385 commented Oct 6, 2015

Copy link
Copy Markdown
Contributor

Show an alert on the task page if it is a scheduled task that has been running for longer than twice the average for tasks in the request. /cc @tpetr

screen shot 2015-10-06 at 3 59 44 pm

@kwm4385

kwm4385 commented Oct 8, 2015

Copy link
Copy Markdown
Contributor Author

Alert if a task is killed due to slave decommissioning.

screen shot 2015-10-08 at 11 53 59 am

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of calculating this yourself, you should use averageRuntimeMillis in the SingularityDeployStatistics object, which can be grabbed from the deploy history endpoint (.../api/history/request/REQUEST_ID/deploy/DEPLOY_ID). it would also be wise to surface warnIfScheduledJobIsRunningPastNextRunPct from https://github.com/HubSpot/Singularity/blob/master/SingularityService/src/main/java/com/hubspot/singularity/config/SingularityConfiguration.java#L172 into the window.config object so that we don't have to hardcode the threshold value

@kwm4385

kwm4385 commented Oct 14, 2015

Copy link
Copy Markdown
Contributor Author

Updated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think this is necessary -- using the value inside SingularityConfiguration is probably good enough

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically we could only make this call only if it's needed (i.e. if the task is scheduled + currently running)

tpetr pushed a commit that referenced this pull request Oct 15, 2015
@tpetr
tpetr merged commit 6d6a23b into master Oct 15, 2015
@tpetr tpetr removed hs_qa labels Oct 15, 2015
@tpetr
tpetr deleted the task_alerts branch October 15, 2015 17:54
@tpetr tpetr added this to the 0.4.6 milestone Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants