Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally take start and end time query params for s3 log search #729

merged 2 commits into from Oct 16, 2015


Copy link

ssalinas commented Oct 9, 2015

this is just an initial thought, not sure if it is the best way to do this but wanted to open for feedback. This is related to our logfetch issue and the fact that /logs/request/{requestId} and even /logs/request/{requestId}/deploy/{deployId} will consistently time out for a service with too many logs. (Think scheduled job that runs every ~10 mins). Also combating this on logfetch side, but this could definitely help

@ssalinas ssalinas force-pushed the s3_logs branch from c1e3556 to 0b9ce60 Oct 9, 2015
public List<SingularityS3Log> getS3LogsForTask(@ApiParam("The task ID to search for") @PathParam("taskId") String taskId) throws Exception {
public List<SingularityS3Log> getS3LogsForTask(
@ApiParam("The task ID to search for") @PathParam("taskId") String taskId,
@ApiParam("Start timestamp (millis, 13 digit)") @QueryParam("start") long start,

This comment has been minimized.


wsorenson Oct 9, 2015 Contributor

Can they not be optional in here?

This comment has been minimized.


ssalinas Oct 12, 2015 Author Member

Not sure you can use Optional in @QueryParam, I think if the query param is not specified it will always come back as a null no matter what the class. I'll double check though

This comment has been minimized.


tpetr Oct 13, 2015 Member

the query params will be zero if not specified (since they're primitive types), so fromNullable() wont work

@tpetr tpetr added the hs_staging label Oct 13, 2015
@ssalinas ssalinas added the hs_qa label Oct 14, 2015
@tpetr tpetr added the hs_stable label Oct 15, 2015
@tpetr tpetr added this to the 0.4.6 milestone Oct 16, 2015
tpetr added a commit that referenced this pull request Oct 16, 2015
optionally take start and end time query params for s3 log search
@tpetr tpetr merged commit b4c1025 into master Oct 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@tpetr tpetr removed hs_qa labels Oct 16, 2015
@ssalinas ssalinas deleted the s3_logs branch Dec 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.