optionally take start and end time query params for s3 log search #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public List<SingularityS3Log> getS3LogsForTask(@ApiParam("The task ID to search for") @PathParam("taskId") String taskId) throws Exception { | ||
| public List<SingularityS3Log> getS3LogsForTask( | ||
| @ApiParam("The task ID to search for") @PathParam("taskId") String taskId, | ||
| @ApiParam("Start timestamp (millis, 13 digit)") @QueryParam("start") long start, |
There was a problem hiding this comment.
Can they not be optional in here?
There was a problem hiding this comment.
Not sure you can use Optional in @QueryParam, I think if the query param is not specified it will always come back as a null no matter what the class. I'll double check though
There was a problem hiding this comment.
the query params will be zero if not specified (since they're primitive types), so fromNullable() wont work
tpetr
pushed a commit
that referenced
this pull request
Oct 16, 2015
optionally take start and end time query params for s3 log search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just an initial thought, not sure if it is the best way to do this but wanted to open for feedback. This is related to our logfetch issue and the fact that
/logs/request/{requestId}and even/logs/request/{requestId}/deploy/{deployId}will consistently time out for a service with too many logs. (Think scheduled job that runs every ~10 mins). Also combating this on logfetch side, but this could definitely help