Skip to content

Change allocated cpu units to floats in the json object#734

Merged
tpetr merged 4 commits into
masterfrom
cpu_calc
Oct 16, 2015
Merged

Change allocated cpu units to floats in the json object#734
tpetr merged 4 commits into
masterfrom
cpu_calc

Conversation

@kwm4385

@kwm4385 kwm4385 commented Oct 15, 2015

Copy link
Copy Markdown
Contributor

/cc @tpetr

@tpetr

tpetr commented Oct 15, 2015

Copy link
Copy Markdown
Contributor

could you use double to match the original protobuf? https://github.com/apache/mesos/blob/0.23.0/include/mesos/mesos.proto#L555-L650

@kwm4385

kwm4385 commented Oct 15, 2015

Copy link
Copy Markdown
Contributor Author

Can do

@tpetr

tpetr commented Oct 16, 2015

Copy link
Copy Markdown
Contributor

@kwm4385 after looking closer, those two fields are supposed to be long, not double, so I dont think they're causing the resources UI bug. made appropriate changes in commit above.

@tpetr tpetr added this to the 0.4.6 milestone Oct 16, 2015
tpetr pushed a commit that referenced this pull request Oct 16, 2015
Change allocated cpu units to floats in the json object
@tpetr tpetr merged commit 9b07057 into master Oct 16, 2015
@tpetr tpetr removed hs_qa labels Oct 16, 2015
@tpetr tpetr deleted the cpu_calc branch October 16, 2015 16:21
@kwm4385

kwm4385 commented Oct 22, 2015

Copy link
Copy Markdown
Contributor Author

@tpetr Does this solve the original issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants