Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change allocated cpu units to floats in the json object #734

Merged
merged 4 commits into from Oct 16, 2015
Merged

Change allocated cpu units to floats in the json object #734

merged 4 commits into from Oct 16, 2015

Conversation

@kwm4385
Copy link
Contributor

kwm4385 commented Oct 15, 2015

/cc @tpetr

@tpetr
Copy link
Member

tpetr commented Oct 15, 2015

could you use double to match the original protobuf? https://github.com/apache/mesos/blob/0.23.0/include/mesos/mesos.proto#L555-L650

@kwm4385
Copy link
Contributor Author

kwm4385 commented Oct 15, 2015

Can do

@tpetr tpetr added the hs_staging label Oct 16, 2015
@tpetr
Copy link
Member

tpetr commented Oct 16, 2015

@kwm4385 after looking closer, those two fields are supposed to be long, not double, so I dont think they're causing the resources UI bug. made appropriate changes in commit above.

@tpetr tpetr added hs_qa labels Oct 16, 2015
fix
@tpetr tpetr added this to the 0.4.6 milestone Oct 16, 2015
tpetr added a commit that referenced this pull request Oct 16, 2015
Change allocated cpu units to floats in the json object
@tpetr tpetr merged commit 9b07057 into master Oct 16, 2015
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@tpetr tpetr removed hs_qa labels Oct 16, 2015
@tpetr tpetr deleted the cpu_calc branch Oct 16, 2015
@kwm4385
Copy link
Contributor Author

kwm4385 commented Oct 22, 2015

@tpetr Does this solve the original issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.