New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request and task links to breadcrumbs on tail view #739

Merged
merged 2 commits into from Nov 3, 2015

Conversation

Projects
None yet
2 participants
@kwm4385
Contributor

kwm4385 commented Oct 23, 2015

screen shot 2015-10-23 at 11 47 33 am

I'm open to discussion on where to place these links. Putting them on their own row above the breadcrumbs took up too much precious vertical space, and making the links their full names instead of Request and Task would end up pushing out any longer file names.

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Oct 28, 2015

Member

what do you think about this?
screen shot 2015-10-28 at 5 34 21 pm

In this way, we're consistent with the breadcrumbs in the task page. If we're smart about padding / margins i think it should be OK

Member

tpetr commented Oct 28, 2015

what do you think about this?
screen shot 2015-10-28 at 5 34 21 pm

In this way, we're consistent with the breadcrumbs in the task page. If we're smart about padding / margins i think it should be OK

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Oct 29, 2015

Contributor

@tpetr Moved them to their own row to match the other pages.

screen shot 2015-10-29 at 11 15 55 am

Contributor

kwm4385 commented Oct 29, 2015

@tpetr Moved them to their own row to match the other pages.

screen shot 2015-10-29 at 11 15 55 am

@tpetr tpetr added this to the 0.4.6 milestone Nov 3, 2015

tpetr added a commit that referenced this pull request Nov 3, 2015

Merge pull request #739 from HubSpot/tail_links
Add request and task links to breadcrumbs on tail view

@tpetr tpetr merged commit ae7e4b6 into master Nov 3, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tpetr tpetr deleted the tail_links branch Nov 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment