Bounce deny #766
Merged
Bounce deny #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (placement != SlavePlacement.GREEDY && placement != SlavePlacement.OPTIMISTIC) { | ||
| int currentActiveSlaveCount = slaveManager.getNumObjectsAtState(MachineState.ACTIVE); | ||
| int requiredSlaveCount = requestWithState.getRequest().getInstancesSafe() * 2; | ||
| checkBadRequest(currentActiveSlaveCount >= requiredSlaveCount, "Not enough slaves to successfully complete a bounce of reqeust %s (minimum required: %s, current: %s)", requestId, requiredSlaveCount, currentActiveSlaveCount); |
There was a problem hiding this comment.
can you clarify this to Not enough active slaves... and maybe include guidance to consider deploying instead of bouncing or changing the slave placement?
| if (placement != SlavePlacement.GREEDY && placement != SlavePlacement.OPTIMISTIC) { | ||
| int currentActiveSlaveCount = slaveManager.getNumObjectsAtState(MachineState.ACTIVE); | ||
| int requiredSlaveCount = requestWithState.getRequest().getInstancesSafe() * 2; | ||
| checkBadRequest(currentActiveSlaveCount >= requiredSlaveCount, "Not enough active slaves to successfully complete a bounce of reqeust %s (minimum required: %s, current: %s). Consider deploying or changing the slave placement strategy instead", requestId, requiredSlaveCount, currentActiveSlaveCount); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
OPTIMISTICandGREEDYit shouldn't matter. But, if placement isSEPARATE*, don't allow us to start a bounce we know we can't complete