bake user query params into authentication system#772
Merged
Conversation
tpetr
pushed a commit
that referenced
this pull request
Nov 24, 2015
bake user query params into authentication system
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
?user=emailauthentication scheme is good for when people are trying Singularity out (i.e. they want to record that user X did an action, but dont want to set up LDAP yet), but required littering all our resource methods with@QueryParam("user"), which began to get nasty.At the same time, many of our resource methods just record the action taker based on the
?user=field, and ignore the injectedOptional<SingularityUser>completely, which can be completely wrong!This PR:
SingularityQueryParamAuthenticator, which keys off of theuserquery paramSingularityDummyDatastore, which always yields a user based off a username with no groups defined for it@QueryParam("user")in favor of using the injectedOptional<SingularityUser>Once this is merged, #759 will function properly.