tweaks to make grepping a file easier #783

Merged
merged 1 commit into from Nov 30, 2015

Conversation

Projects
None yet
2 participants
@tpetr
Member

tpetr commented Nov 25, 2015

  • Don't grep if the grep query param is empty
  • Add optional nextOffset field to MesosFileChunkObject, and if grepping, relay what the next file offset should be (needed for the UI). If nextOffset is not set, it's safe to assume the next offset you should grab is offset + data.length.

/cc @kwm4385

@tpetr tpetr added the hs_staging label Nov 25, 2015

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Nov 25, 2015

Contributor

💃

Contributor

kwm4385 commented Nov 25, 2015

💃

@tpetr tpetr added the hs_qa label Nov 25, 2015

@tpetr tpetr added this to the 0.4.6 milestone Nov 25, 2015

@tpetr tpetr added the hs_stable label Nov 30, 2015

tpetr added a commit that referenced this pull request Nov 30, 2015

Merge pull request #783 from HubSpot/grep-tweaks
tweaks to make grepping a file easier

@tpetr tpetr merged commit 1d8f2e0 into master Nov 30, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tpetr tpetr deleted the grep-tweaks branch Nov 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment