Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweaks to make grepping a file easier #783

Merged
merged 1 commit into from Nov 30, 2015
Merged

tweaks to make grepping a file easier #783

merged 1 commit into from Nov 30, 2015

Conversation

@tpetr
Copy link
Member

tpetr commented Nov 25, 2015

  • Don't grep if the grep query param is empty
  • Add optional nextOffset field to MesosFileChunkObject, and if grepping, relay what the next file offset should be (needed for the UI). If nextOffset is not set, it's safe to assume the next offset you should grab is offset + data.length.

/cc @kwm4385

@tpetr tpetr added the hs_staging label Nov 25, 2015
@kwm4385
Copy link
Contributor

kwm4385 commented Nov 25, 2015

💃

@tpetr tpetr added the hs_qa label Nov 25, 2015
@tpetr tpetr added this to the 0.4.6 milestone Nov 25, 2015
@tpetr tpetr added the hs_stable label Nov 30, 2015
tpetr added a commit that referenced this pull request Nov 30, 2015
tweaks to make grepping a file easier
@tpetr tpetr merged commit 1d8f2e0 into master Nov 30, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tpetr tpetr deleted the grep-tweaks branch Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.