New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for default healthcheckMaxRetries and healthcheckMaxTotalTimeoutSeconds values in SingularityConfiguration #786

Merged
merged 1 commit into from Dec 7, 2015

Conversation

Projects
None yet
2 participants
@tpetr
Member

tpetr commented Dec 3, 2015

add support for default healthcheckMaxRetries and healthcheckMaxTotal…
…TimeoutSeconds values in SingularityConfiguration

@tpetr tpetr added the hs_staging label Dec 3, 2015

@@ -102,6 +102,12 @@
private long healthcheckTimeoutSeconds = 5;
@NotNull
private Optional<Integer> healthcheckMaxRetries = Optional.absent();

This comment has been minimized.

@wsorenson

wsorenson Dec 3, 2015

Member

I like that you used Optionals here. Previously, I had set Integers or Longs to -1 to disable them. This is better.

@wsorenson

wsorenson Dec 3, 2015

Member

I like that you used Optionals here. Previously, I had set Integers or Longs to -1 to disable them. This is better.

@tpetr tpetr added the hs_qa label Dec 4, 2015

@tpetr tpetr added this to the 0.4.6 milestone Dec 6, 2015

@tpetr tpetr added the hs_stable label Dec 6, 2015

tpetr added a commit that referenced this pull request Dec 7, 2015

Merge pull request #786 from HubSpot/hc-timeout-defaults
add support for default healthcheckMaxRetries and healthcheckMaxTotalTimeoutSeconds values in SingularityConfiguration

@tpetr tpetr merged commit 41568c9 into master Dec 7, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tpetr tpetr deleted the hc-timeout-defaults branch Dec 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment