Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for default healthcheckMaxRetries and healthcheckMaxTotalTimeoutSeconds values in SingularityConfiguration #786

Merged
merged 1 commit into from Dec 7, 2015

Conversation

tpetr
Copy link
Contributor

@tpetr tpetr commented Dec 3, 2015

…TimeoutSeconds values in SingularityConfiguration
@@ -102,6 +102,12 @@

private long healthcheckTimeoutSeconds = 5;

@NotNull
private Optional<Integer> healthcheckMaxRetries = Optional.absent();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you used Optionals here. Previously, I had set Integers or Longs to -1 to disable them. This is better.

@tpetr tpetr added the hs_qa label Dec 4, 2015
@tpetr tpetr added this to the 0.4.6 milestone Dec 6, 2015
@tpetr tpetr added the hs_stable label Dec 6, 2015
tpetr pushed a commit that referenced this pull request Dec 7, 2015
add support for default healthcheckMaxRetries and healthcheckMaxTotalTimeoutSeconds values in SingularityConfiguration
@tpetr tpetr merged commit 41568c9 into master Dec 7, 2015
@tpetr tpetr removed hs_qa labels Dec 7, 2015
@tpetr tpetr deleted the hc-timeout-defaults branch December 7, 2015 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants