Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to also bounce when scaling #795

Merged
merged 9 commits into from Dec 18, 2015
Merged

Add option to also bounce when scaling #795

merged 9 commits into from Dec 18, 2015

Conversation

ssalinas
Copy link
Member

screen shot 2015-12-10 at 10 12 58 am
(extra options for incremental bounce only appear when bounce is checked)

return unless data
bounce = $('.vex #bounce').is ':checked'
incremental = $('.vex #incremental-bounce').is ':checked'
@scale(data, bounce, incremental).done =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come you're passing bounce and incremental to @scale()?

@ssalinas
Copy link
Member Author

@tpetr updated form your comments, also the checkbox label just says "Bounce after scaling" now

@ssalinas
Copy link
Member Author

Added a field in the request so that you can default that box to checked if you want

@@ -229,6 +232,10 @@ public ScheduleType getScheduleTypeSafe() {
return readOnlyGroups;
}

public boolean isBounceAfterScale() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need one that is the Json getter that just returns the actual value.

If you want to add a helper, you should @JsonIgnore it.

@wsorenson
Copy link
Contributor

Is the request option only used by the UI?

@ssalinas
Copy link
Member Author

Yes, only used by the ui. Developers wanted a way to have the checkbox default to checked for some requests but not others

@tpetr
Copy link
Contributor

tpetr commented Dec 17, 2015

This could be addressed in a subsequent PR, but I think it'd be worth packing the bounce + scale functionality into the backend. The "dumber" the UI is, the better.

<label for="bounce" id="bounce-label">
<input type="checkbox" id="bounce"{{#if bounceAfterScale}} checked{{/if}}>
Bounce after scaling
</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider moving the bounce checkbox to after the scale input to fit in with the "bounce after scaling" wording.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bonus points for indenting the incremental bounce option + greying it out if the bounce checkmark is unchecked

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now the incremental option isn't show if bounce checkmark is unchecked and appears when you check it. would you rather see it greyed out instead of having it hidden?

@ssalinas
Copy link
Member Author

New look of the prompt (radio buttons are hidden when bounce isn't checked):
screen shot 2015-12-18 at 8 49 07 am

tpetr pushed a commit that referenced this pull request Dec 18, 2015
Add option to also bounce when scaling
@tpetr tpetr merged commit 896444e into master Dec 18, 2015
@tpetr tpetr removed hs_qa labels Dec 18, 2015
@tpetr tpetr added this to the 0.4.6 milestone Dec 18, 2015
@ssalinas ssalinas deleted the bounce_and_scale branch December 21, 2015 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants