GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(extra options for incremental bounce only appear when bounce is checked)
Merge branch 'incremental_bounce' into bounce_and_scale
option to also bounce when scaling
ui option tweaks
Merge branch 'master' into bounce_and_scale
how come you're passing bounce and incremental to @scale()?
we should figure out a way to do this in the view instead
hide/show update, message update
@tpetr updated form your comments, also the checkbox label just says "Bounce after scaling" now
add bounceAfterScale param to default checkbox for request
Added a field in the request so that you can default that box to checked if you want
You need one that is the Json getter that just returns the actual value.
If you want to add a helper, you should @JsonIGnore it.
Is the request option only used by the UI?
Yes, only used by the ui. Developers wanted a way to have the checkbox default to checked for some requests but not others
proper getter for bounceAfterScale
This could be addressed in a subsequent PR, but I think it'd be worth packing the bounce + scale functionality into the backend. The "dumber" the UI is, the better.
I'd consider moving the bounce checkbox to after the scale input to fit in with the "bounce after scaling" wording.
bonus points for indenting the incremental bounce option + greying it out if the bounce checkmark is unchecked
right now the incremental option isn't show if bounce checkmark is unchecked and appears when you check it. would you rather see it greyed out instead of having it hidden?
new layout for scale prompt
New look of the prompt (radio buttons are hidden when bounce isn't checked):
show options if bounce checked by default
Merge pull request #795 from HubSpot/bounce_and_scale
Add option to also bounce when scaling