Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make files table in task view sortable #796

Merged
merged 4 commits into from Dec 18, 2015
Merged

make files table in task view sortable #796

merged 4 commits into from Dec 18, 2015

Conversation

ssalinas
Copy link
Member

No description provided.

@kwm4385
Copy link
Contributor

kwm4385 commented Dec 11, 2015

@ssalinas Just tweaked an attr so we don't sort on the last column.

@ssalinas
Copy link
Member Author

Cool, thanks

@tpetr
Copy link
Contributor

tpetr commented Dec 15, 2015

  • Seeing some weirdness when sorting by Size:
    screen shot 2015-12-15 at 11 45 47 am
    screen shot 2015-12-15 at 11 47 25 am
  • Task refresh blows away the sort setting

@ssalinas
Copy link
Member Author

@tpetr believe I have fixed the odd sorting now, we had some odd stuff going on with data-value which is used by sortable. Probably due to an older way of doing sorting. Still need to fix the task refresh piece

@ssalinas
Copy link
Member Author

Actually, sort clearing on task refresh might be part of a larger problem, looks like sorts do that on all of our pages, not just here

@tpetr
Copy link
Contributor

tpetr commented Dec 18, 2015

LGTM -- let's revisit the sort clearing on refresh in a separate PR

tpetr pushed a commit that referenced this pull request Dec 18, 2015
make files table in task view sortable
@tpetr tpetr merged commit 793e070 into master Dec 18, 2015
@tpetr tpetr added this to the 0.4.6 milestone Dec 18, 2015
@tpetr tpetr removed hs_qa labels Dec 18, 2015
@ssalinas ssalinas deleted the sortable_files branch December 21, 2015 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants