New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make files table in task view sortable #796

Merged
merged 4 commits into from Dec 18, 2015

Conversation

Projects
None yet
3 participants
@ssalinas
Member

ssalinas commented Dec 10, 2015

No description provided.

@ssalinas ssalinas added the hs_staging label Dec 10, 2015

@kwm4385

This comment has been minimized.

Show comment
Hide comment
@kwm4385

kwm4385 Dec 11, 2015

Contributor

@ssalinas Just tweaked an attr so we don't sort on the last column.

Contributor

kwm4385 commented Dec 11, 2015

@ssalinas Just tweaked an attr so we don't sort on the last column.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Dec 11, 2015

Member

Cool, thanks

Member

ssalinas commented Dec 11, 2015

Cool, thanks

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Dec 15, 2015

Member
  • Seeing some weirdness when sorting by Size:
    screen shot 2015-12-15 at 11 45 47 am
    screen shot 2015-12-15 at 11 47 25 am
  • Task refresh blows away the sort setting
Member

tpetr commented Dec 15, 2015

  • Seeing some weirdness when sorting by Size:
    screen shot 2015-12-15 at 11 45 47 am
    screen shot 2015-12-15 at 11 47 25 am
  • Task refresh blows away the sort setting
@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Dec 17, 2015

Member

@tpetr believe I have fixed the odd sorting now, we had some odd stuff going on with data-value which is used by sortable. Probably due to an older way of doing sorting. Still need to fix the task refresh piece

Member

ssalinas commented Dec 17, 2015

@tpetr believe I have fixed the odd sorting now, we had some odd stuff going on with data-value which is used by sortable. Probably due to an older way of doing sorting. Still need to fix the task refresh piece

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Dec 17, 2015

Member

Actually, sort clearing on task refresh might be part of a larger problem, looks like sorts do that on all of our pages, not just here

Member

ssalinas commented Dec 17, 2015

Actually, sort clearing on task refresh might be part of a larger problem, looks like sorts do that on all of our pages, not just here

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Dec 18, 2015

Member

LGTM -- let's revisit the sort clearing on refresh in a separate PR

Member

tpetr commented Dec 18, 2015

LGTM -- let's revisit the sort clearing on refresh in a separate PR

tpetr added a commit that referenced this pull request Dec 18, 2015

Merge pull request #796 from HubSpot/sortable_files
make files table in task view sortable

@tpetr tpetr merged commit 793e070 into master Dec 18, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tpetr tpetr added this to the 0.4.6 milestone Dec 18, 2015

@ssalinas ssalinas deleted the sortable_files branch Dec 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment