Get task info by runId #813
Conversation
| @@ -29,6 +29,9 @@ | |||
| @SqlQuery("SELECT bytes FROM taskHistory WHERE taskId = :taskId") | |||
| byte[] getTaskHistoryForTask(@Bind("taskId") String taskId); | |||
|
|
|||
| @SqlQuery("SELECT bytes FROM taskHistory WHERE runId = :runId") | |||
| byte[] getTaskHistoryForTaskByRunId(@Bind("runId") String runId); | |||
There was a problem hiding this comment.
Shouldn't this also filter by requestId?
| @@ -29,6 +29,9 @@ | |||
| @SqlQuery("SELECT bytes FROM taskHistory WHERE taskId = :taskId") | |||
| byte[] getTaskHistoryForTask(@Bind("taskId") String taskId); | |||
|
|
|||
| @SqlQuery("SELECT bytes FROM taskHistory WHERE requestId = :requestId AND runId = :runId") | |||
| byte[] getTaskHistoryForTaskByRunId(@Bind("requestId") String requestId, @Bind("runId") String runId); | |||
There was a problem hiding this comment.
not currently, we would probably need to for this case
There was a problem hiding this comment.
yeah, we should add an index. let me know if you need a hand with this.
There was a problem hiding this comment.
Added an index in b63cf47 , can someone with more mysql chops double check that please?
There was a problem hiding this comment.
syncing up w/ monty about this
There was a problem hiding this comment.
Which query/queries will benefit from the added index in b63cf47?
There was a problem hiding this comment.
The one on the line for this comment thread:
SELECT bytes FROM taskHistory WHERE requestId = :requestId AND runId = :runId
|
Updated a couple things, had forgotten about the description, thanks for that |
|
This PR reads like there was an assumption that |
Get the
SingularityTaskIdHistoryobject for a task by it's run id/cc @jhaber this should get you back taskId, last state, and the SingularityTaskId object