Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Incremental deploys #817
Still needs plenty of work, but opening up early for feedback.
Right now I am adding a field to the
The basics are working now. All deploys now use a similar system where progress is tracked in the pending deploy object, incrementing a target number of instances for each step of the deploy. By default the number of instances per deploy step is the total instances (i.e. everything at once like before) unless a
Some info is surfaced in the ui now on the request page, but the wording/design could probably still be a bit cleaner.
This is working pretty solidly now. Each deploy for a longRunning request has a
When advancing the deploy, you can then select the next target number of instances (defaults to current target + deployInstancesPerStep) allowing you to step the deploy forward or backwards:
The manual advance can also override the timed advance. The deploy checker checks for the presence of a request to manually advance the deploy as well as the expiration of the wait time.