be sure to check deploy health for incremental bounce#827
Merged
Conversation
Contributor
|
You should add a test which fails pre-PR and succeeds post-PR. |
Contributor
Author
|
@wsorenson turns out the previous test I wrote for incremental bounce served that pretty well with some modifications. I extended it so that there is an explicit check that a old tasks will not shut down from a task in |
wsorenson
added a commit
that referenced
this pull request
Jan 4, 2016
be sure to check deploy health for incremental bounce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @wsorenson for pointing this out. I reworked/reordered the if statements so that we will check the health of the matching tasks for incremental deploys as well before deciding if we can shut a task down
/cc @tpetr