New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be sure to check deploy health for incremental bounce #827

Merged
merged 3 commits into from Jan 4, 2016

Conversation

Projects
None yet
3 participants
@ssalinas
Member

ssalinas commented Dec 30, 2015

Thanks @wsorenson for pointing this out. I reworked/reordered the if statements so that we will check the health of the matching tasks for incremental deploys as well before deciding if we can shut a task down

/cc @tpetr

@wsorenson

This comment has been minimized.

Show comment
Hide comment
@wsorenson

wsorenson Dec 30, 2015

Member

You should add a test which fails pre-PR and succeeds post-PR.

Member

wsorenson commented Dec 30, 2015

You should add a test which fails pre-PR and succeeds post-PR.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Dec 30, 2015

Member

@wsorenson turns out the previous test I wrote for incremental bounce served that pretty well with some modifications. I extended it so that there is an explicit check that a old tasks will not shut down from a task in TASK_RUNNING but without a passing healthcheck.

Member

ssalinas commented Dec 30, 2015

@wsorenson turns out the previous test I wrote for incremental bounce served that pretty well with some modifications. I extended it so that there is an explicit check that a old tasks will not shut down from a task in TASK_RUNNING but without a passing healthcheck.

@tpetr tpetr added this to the 0.4.8 milestone Dec 31, 2015

wsorenson added a commit that referenced this pull request Jan 4, 2016

Merge pull request #827 from HubSpot/incremental_health
be sure to check deploy health for incremental bounce

@wsorenson wsorenson merged commit fc72046 into master Jan 4, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment