make sure literal host ports are processed correctly #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tpetr this should be gtg, thoughts on merging? |
| for (long port : requestedPorts) { | ||
| if (rangeStartSelection >= port && rangeEndSelection <= port) { | ||
| toRemove.add(port); | ||
| portsSoFar --; |
There was a problem hiding this comment.
i'd remove the space here for clarity
There was a problem hiding this comment.
sry, missed this comment before, fixed
|
@tpetr added the JsonIgnore, this should be good now |
|
LGTM |
ssalinas
added a commit
that referenced
this pull request
Jan 22, 2016
make sure literal host ports are processed correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things to fix ports/params with docker:
LITERALmapping also gets added to the mesos Resources when building the taskdoesOfferMatchResourcesthat any requested literal host ports are present in the offerparamsmake it onto the mesos task definition and add a MesosUtilsTest assertion for this and the literal ports/fyi @chrisbrewer @wsorenson