Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure literal host ports are processed correctly #837

Merged
merged 8 commits into from Jan 22, 2016
Merged

Conversation

@ssalinas
Copy link
Member

ssalinas commented Jan 7, 2016

A few things to fix ports/params with docker:

  • Make sure any port with a LITERAL mapping also gets added to the mesos Resources when building the task
  • Verify during doesOfferMatchResources that any requested literal host ports are present in the offer
  • Add a scheduler test for port resources
  • Make sure docker params make it onto the mesos task definition and add a MesosUtilsTest assertion for this and the literal ports

/fyi @chrisbrewer @wsorenson

@ssalinas ssalinas added the hs_staging label Jan 7, 2016
@ssalinas ssalinas added this to the 0.4.8 milestone Jan 7, 2016
ssalinas added 2 commits Jan 7, 2016
@ssalinas
Copy link
Member Author

ssalinas commented Jan 11, 2016

@tpetr this should be gtg, thoughts on merging?

for (long port : requestedPorts) {
if (rangeStartSelection >= port && rangeEndSelection <= port) {
toRemove.add(port);
portsSoFar --;

This comment has been minimized.

Copy link
@tpetr

tpetr Jan 11, 2016

Member

i'd remove the space here for clarity

This comment has been minimized.

Copy link
@ssalinas

ssalinas Jan 12, 2016

Author Member

sry, missed this comment before, fixed

@tpetr tpetr modified the milestones: 0.4.8, 0.4.9 Jan 15, 2016
@ssalinas
Copy link
Member Author

ssalinas commented Jan 22, 2016

@tpetr added the JsonIgnore, this should be good now

@tpetr
Copy link
Member

tpetr commented Jan 22, 2016

LGTM

ssalinas added a commit that referenced this pull request Jan 22, 2016
make sure literal host ports are processed correctly
@ssalinas ssalinas merged commit 0463204 into master Jan 22, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ssalinas ssalinas deleted the docker_literal_port branch Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.