Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure literal host ports are processed correctly #837

Merged
merged 8 commits into from Jan 22, 2016

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Jan 7, 2016

A few things to fix ports/params with docker:

  • Make sure any port with a LITERAL mapping also gets added to the mesos Resources when building the task
  • Verify during doesOfferMatchResources that any requested literal host ports are present in the offer
  • Add a scheduler test for port resources
  • Make sure docker params make it onto the mesos task definition and add a MesosUtilsTest assertion for this and the literal ports

/fyi @chrisbrewer @wsorenson

@ssalinas ssalinas added this to the 0.4.8 milestone Jan 7, 2016
@ssalinas
Copy link
Member Author

ssalinas commented Jan 11, 2016

@tpetr this should be gtg, thoughts on merging?

for (long port : requestedPorts) {
if (rangeStartSelection >= port && rangeEndSelection <= port) {
toRemove.add(port);
portsSoFar --;
Copy link
Contributor

@tpetr tpetr Jan 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd remove the space here for clarity

Copy link
Member Author

@ssalinas ssalinas Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sry, missed this comment before, fixed

@tpetr tpetr modified the milestones: 0.4.8, 0.4.9 Jan 15, 2016
@ssalinas
Copy link
Member Author

ssalinas commented Jan 22, 2016

@tpetr added the JsonIgnore, this should be good now

@tpetr
Copy link
Contributor

tpetr commented Jan 22, 2016

LGTM

ssalinas added a commit that referenced this issue Jan 22, 2016
make sure literal host ports are processed correctly
@ssalinas ssalinas merged commit 0463204 into master Jan 22, 2016
0 of 2 checks passed
@ssalinas ssalinas deleted the docker_literal_port branch Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants