make sure literal host ports are processed correctly #837

Merged
merged 8 commits into from Jan 22, 2016

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Jan 7, 2016

A few things to fix ports/params with docker:

  • Make sure any port with a LITERAL mapping also gets added to the mesos Resources when building the task
  • Verify during doesOfferMatchResources that any requested literal host ports are present in the offer
  • Add a scheduler test for port resources
  • Make sure docker params make it onto the mesos task definition and add a MesosUtilsTest assertion for this and the literal ports

/fyi @chrisbrewer @wsorenson

@ssalinas ssalinas added the hs_staging label Jan 7, 2016

@ssalinas ssalinas added this to the 0.4.8 milestone Jan 7, 2016

ssalinas added some commits Jan 7, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jan 11, 2016

Member

@tpetr this should be gtg, thoughts on merging?

Member

ssalinas commented Jan 11, 2016

@tpetr this should be gtg, thoughts on merging?

+ for (long port : requestedPorts) {
+ if (rangeStartSelection >= port && rangeEndSelection <= port) {
+ toRemove.add(port);
+ portsSoFar --;

This comment has been minimized.

@tpetr

tpetr Jan 11, 2016

Member

i'd remove the space here for clarity

@tpetr

tpetr Jan 11, 2016

Member

i'd remove the space here for clarity

This comment has been minimized.

@ssalinas

ssalinas Jan 12, 2016

Member

sry, missed this comment before, fixed

@ssalinas

ssalinas Jan 12, 2016

Member

sry, missed this comment before, fixed

@tpetr tpetr modified the milestones: 0.4.8, 0.4.9 Jan 15, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jan 22, 2016

Member

@tpetr added the JsonIgnore, this should be good now

Member

ssalinas commented Jan 22, 2016

@tpetr added the JsonIgnore, this should be good now

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Jan 22, 2016

Member

LGTM

Member

tpetr commented Jan 22, 2016

LGTM

ssalinas added a commit that referenced this pull request Jan 22, 2016

Merge pull request #837 from HubSpot/docker_literal_port
make sure literal host ports are processed correctly

@ssalinas ssalinas merged commit 0463204 into master Jan 22, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ssalinas ssalinas deleted the docker_literal_port branch Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment