Task search #839
Merged
Task search #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wsorenson
commented
Jan 11, 2016
wsorenson
commented
- needs UX
| @ApiParam("Request ID to look up") @PathParam("requestId") String requestId, | ||
| @ApiParam("Request ID to match") @PathParam("requestId") String requestId, | ||
| @ApiParam("Optional deploy ID to match") @QueryParam("deployId") Optional<String> deployId, | ||
| @ApiParam("Optional host to match") @QueryParam("deployId") Optional<String> host, |
There was a problem hiding this comment.
just noticed this one, @QueryParam is still deployId here instead of host
make sure request history always in correct order
revert sorting changes for request history
added 8 commits
January 28, 2016 12:54
…e that maybe should be held by the TaskSearch page instead
…k to the form page. Yay! Also some code organizational changes.
…k to the form page. Yay! Also some code organizational changes. And added files that weren't in the previous commit by accident
(WIP) task search efficiency
…Results collections into HistoricalTasks
smarter ordering for queries that don't use zk first
Refactor HistoricalTasks Collections into One
Task Search UI
| - `startedBefore`: Optionally match only tasks started before this time (13 digit unix timestamp) | ||
| - `orderDirection`: Sort direction (by `startedAt`), can be ASC or DESC, defaults to DESC (newest tasks first) | ||
| - `count`: Maximum number of items to return | ||
| - `page`: Page of items to view (e.g. page 1 is the first `count` items, page 2 is the next `count` items) |
There was a problem hiding this comment.
Count and page are optional too. Page defaults to 1, and I believe count defaults to infinite but I don't remember exactly.
There was a problem hiding this comment.
ah, yeah, good to include defaults, I'll add them in
There was a problem hiding this comment.
The defaults would be nice to have in api.md too, though it looks like space is limited there. (I can't add line notes to api.md because the diff is so big Github won't show it to me)
There was a problem hiding this comment.
Yeah, we need to do some fooling with swagger at some point, that will probably end up being a separate PR some time
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.