Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task search #839

Merged
merged 132 commits into from Mar 24, 2016
Merged

Task search #839

merged 132 commits into from Mar 24, 2016

Conversation

wsorenson
Copy link
Contributor

  • needs UX

@ApiParam("Request ID to look up") @PathParam("requestId") String requestId,
@ApiParam("Request ID to match") @PathParam("requestId") String requestId,
@ApiParam("Optional deploy ID to match") @QueryParam("deployId") Optional<String> deployId,
@ApiParam("Optional host to match") @QueryParam("deployId") Optional<String> host,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed this one, @QueryParam is still deployId here instead of host

@tpetr tpetr modified the milestone: 0.4.9 Jan 27, 2016
@ssalinas ssalinas changed the title (WIP) Task search Task search Mar 14, 2016
- `startedBefore`: Optionally match only tasks started before this time (13 digit unix timestamp)
- `orderDirection`: Sort direction (by `startedAt`), can be ASC or DESC, defaults to DESC (newest tasks first)
- `count`: Maximum number of items to return
- `page`: Page of items to view (e.g. page 1 is the first `count` items, page 2 is the next `count` items)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Count and page are optional too. Page defaults to 1, and I believe count defaults to infinite but I don't remember exactly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yeah, good to include defaults, I'll add them in

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The defaults would be nice to have in api.md too, though it looks like space is limited there. (I can't add line notes to api.md because the diff is so big Github won't show it to me)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we need to do some fooling with swagger at some point, that will probably end up being a separate PR some time

@ssalinas ssalinas merged commit 5532749 into master Mar 24, 2016
@ssalinas ssalinas deleted the task_search branch March 24, 2016 15:50
@Calvinp
Copy link
Contributor

Calvinp commented Mar 24, 2016

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants