Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task search #839

Merged
merged 132 commits into from Mar 24, 2016
Merged

Task search #839

merged 132 commits into from Mar 24, 2016

Conversation

@wsorenson
Copy link
Contributor

wsorenson commented Jan 11, 2016

  • needs UX
@ApiParam("Request ID to look up") @PathParam("requestId") String requestId,
@ApiParam("Request ID to match") @PathParam("requestId") String requestId,
@ApiParam("Optional deploy ID to match") @QueryParam("deployId") Optional<String> deployId,
@ApiParam("Optional host to match") @QueryParam("deployId") Optional<String> host,

This comment has been minimized.

@ssalinas

ssalinas Jan 20, 2016 Member

just noticed this one, @QueryParam is still deployId here instead of host

@ApiParam("Optional last task status to match") @QueryParam("lastTaskStatus") Optional<ExtendedTaskState> lastTaskStatus,
@ApiParam("Optionally match only tasks started after") @QueryParam("startedAfter") Optional<Long> startedAfter,
@ApiParam("Optionally match only tasks started before") @QueryParam("startedBefore") Optional<Long> startedBefore,
@ApiParam("Sort direction") @QueryParam("startBefore") Optional<OrderDirection> orderDirection,

This comment has been minimized.

@ssalinas

ssalinas Jan 20, 2016 Member

Same with this @QueryParam (orderDirection)

This comment has been minimized.

@wsorenson

wsorenson Jan 20, 2016 Author Contributor

💯 for code review

wsorenson and others added 9 commits Jan 20, 2016
make sure request history always in correct order
revert sorting changes for request history
@tpetr tpetr modified the milestone: 0.4.9 Jan 27, 2016
Calvinp added 8 commits Jan 28, 2016
…e that maybe should be held by the TaskSearch page instead
…k to the form page. Yay! Also some code organizational changes.
…k to the form page. Yay! Also some code organizational changes. And added files that weren't in the previous commit by accident
ssalinas and others added 12 commits Mar 3, 2016
(WIP) task search efficiency
…Results collections into HistoricalTasks
smarter ordering for queries that don't use zk first
Refactor HistoricalTasks Collections into One
Task Search UI
@ssalinas ssalinas changed the title (WIP) Task search Task search Mar 14, 2016
ssalinas added 2 commits Mar 14, 2016
@ssalinas ssalinas added the hs_stable label Mar 17, 2016
- `startedBefore`: Optionally match only tasks started before this time (13 digit unix timestamp)
- `orderDirection`: Sort direction (by `startedAt`), can be ASC or DESC, defaults to DESC (newest tasks first)
- `count`: Maximum number of items to return
- `page`: Page of items to view (e.g. page 1 is the first `count` items, page 2 is the next `count` items)

This comment has been minimized.

@Calvinp

Calvinp Mar 24, 2016 Contributor

Count and page are optional too. Page defaults to 1, and I believe count defaults to infinite but I don't remember exactly.

This comment has been minimized.

@ssalinas

ssalinas Mar 24, 2016 Member

ah, yeah, good to include defaults, I'll add them in

This comment has been minimized.

@Calvinp

Calvinp Mar 24, 2016 Contributor

The defaults would be nice to have in api.md too, though it looks like space is limited there. (I can't add line notes to api.md because the diff is so big Github won't show it to me)

This comment has been minimized.

@ssalinas

ssalinas Mar 24, 2016 Member

Yeah, we need to do some fooling with swagger at some point, that will probably end up being a separate PR some time


`/api/history/tasks` -> Retrieve the history sorted by startedAt for all inactive tasks.

... and the above endpoint as well `/api/history/request/{requestId}/tasks` now take additonal query parameters:

This comment has been minimized.

@Calvinp

Calvinp Mar 24, 2016 Contributor

This line is kind of confusing to me. Maybe 'The above endpoint as well as /api/history/request/{requestId}/tasks now take additonal query parameters'

ssalinas added 3 commits Mar 24, 2016
@ssalinas ssalinas merged commit 5532749 into master Mar 24, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ssalinas ssalinas deleted the task_search branch Mar 24, 2016
@ssalinas ssalinas removed hs_qa labels Mar 24, 2016
@Calvinp
Copy link
Contributor

Calvinp commented Mar 24, 2016

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.