Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to client for unpause and scale requests #854

Merged
merged 3 commits into from Feb 4, 2016

Conversation

@compyman
Copy link

compyman commented Jan 21, 2016

No description provided.

@ssalinas ssalinas added the hs_staging label Jan 22, 2016
@ssalinas
Copy link
Member

ssalinas commented Jan 22, 2016

Thanks for the PR @bacchus123 ! LGTM

@@ -323,9 +327,25 @@ private void addCredentials(HttpRequest.Builder requestBuilder) {
return Optional.absent();
}

private <T> Optional<T> put(String uri, String type, Optional<?> body, Optional<Class<T>> clazz) {

This comment has been minimized.

Copy link
@tpetr

tpetr Jan 22, 2016

Member

it looks like this method is unused, and is causing findbugs to barf. could you remove this method to make the build pass?

@tpetr tpetr removed the hs_staging label Jan 22, 2016
@tpetr
Copy link
Member

tpetr commented Jan 22, 2016

Pulled out of hs_staging due to failing build via ba6bf5f

Nate Rosenbloom added 2 commits Jan 22, 2016
Nate Rosenbloom
Nate Rosenbloom
@compyman
Copy link
Author

compyman commented Jan 25, 2016

this builds locally with
mvn clean install fine so I'm not sure what I need to fix??

@tpetr
Copy link
Member

tpetr commented Jan 25, 2016

build with mvn clean verify to ensure that checkstyle, findbug, etc. all run

@compyman
Copy link
Author

compyman commented Jan 25, 2016

I ran mvn clean verify and all projects completed successfully

@ssalinas ssalinas added the hs_staging label Jan 25, 2016
@ssalinas
Copy link
Member

ssalinas commented Jan 25, 2016

Thanks for fixing @bacchus123 , I put this back into staging

@tpetr tpetr modified the milestone: 0.4.9 Jan 27, 2016
@tpetr tpetr modified the milestones: 0.4.9, 0.4.10 Feb 2, 2016
ssalinas added a commit that referenced this pull request Feb 4, 2016
Add methods to client for unpause and scale requests
@ssalinas ssalinas merged commit dfb2cb3 into HubSpot:master Feb 4, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.