Skip to content

Add methods to client for unpause and scale requests#854

Merged
ssalinas merged 3 commits into
HubSpot:masterfrom
compyman:addScaleAndUnpauseMethods
Feb 4, 2016
Merged

Add methods to client for unpause and scale requests#854
ssalinas merged 3 commits into
HubSpot:masterfrom
compyman:addScaleAndUnpauseMethods

Conversation

@compyman
Copy link
Copy Markdown

No description provided.

@ssalinas
Copy link
Copy Markdown
Contributor

Thanks for the PR @bacchus123 ! LGTM

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this method is unused, and is causing findbugs to barf. could you remove this method to make the build pass?

@tpetr tpetr removed the hs_staging label Jan 22, 2016
@tpetr
Copy link
Copy Markdown
Contributor

tpetr commented Jan 22, 2016

Pulled out of hs_staging due to failing build via ba6bf5f

@compyman
Copy link
Copy Markdown
Author

this builds locally with
mvn clean install fine so I'm not sure what I need to fix??

@tpetr
Copy link
Copy Markdown
Contributor

tpetr commented Jan 25, 2016

build with mvn clean verify to ensure that checkstyle, findbug, etc. all run

@compyman
Copy link
Copy Markdown
Author

I ran mvn clean verify and all projects completed successfully

@ssalinas
Copy link
Copy Markdown
Contributor

Thanks for fixing @bacchus123 , I put this back into staging

@tpetr tpetr modified the milestone: 0.4.9 Jan 27, 2016
@tpetr tpetr modified the milestones: 0.4.9, 0.4.10 Feb 2, 2016
ssalinas added a commit that referenced this pull request Feb 4, 2016
Add methods to client for unpause and scale requests
@ssalinas ssalinas merged commit dfb2cb3 into HubSpot:master Feb 4, 2016
@compyman compyman deleted the addScaleAndUnpauseMethods branch April 19, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants