Fix the sorting in the wrong order bug. #860

Merged
merged 2 commits into from Feb 4, 2016

Conversation

Projects
None yet
4 participants
@Calvinp
Contributor

Calvinp commented Jan 26, 2016

When more than 10 files were present in a task, the sort order became very wrong in Chrome. Manually overriding the sort order would cause files to jump around.
This fixes the wrong initial sort order. Unfortunately files will still jump around, but that can be avoided by not manually sorting the table.

Fix the sorting in the wrong order order bug. This will not fix jumpi…
…ng files, but that will only happen when you manually change the sort order or a new file is added.
@wsorenson

This comment has been minimized.

Show comment
Hide comment
@wsorenson

wsorenson Jan 26, 2016

Member

Why do files still jump around?

Member

wsorenson commented Jan 26, 2016

Why do files still jump around?

@Calvinp

This comment has been minimized.

Show comment
Hide comment
@Calvinp

Calvinp Jan 26, 2016

Contributor

The page refreshes fairly often (I think whenever it becomes in focus), so if you manually override the sort order it will refresh back to the default sort order.

Contributor

Calvinp commented Jan 26, 2016

The page refreshes fairly often (I think whenever it becomes in focus), so if you manually override the sort order it will refresh back to the default sort order.

@wsorenson

This comment has been minimized.

Show comment
Hide comment
@wsorenson

wsorenson Jan 26, 2016

Member
  • Is there a way to pull the elements without refreshing the page and changing client interactions like sort order?
  • Is there a way to persist changes like sort order after refresh?

Curious if this is related to standard backbone issues and thus there should be a well-known workaround. I'd check with other FE resources.

Member

wsorenson commented Jan 26, 2016

  • Is there a way to pull the elements without refreshing the page and changing client interactions like sort order?
  • Is there a way to persist changes like sort order after refresh?

Curious if this is related to standard backbone issues and thus there should be a well-known workaround. I'd check with other FE resources.

@Calvinp

This comment has been minimized.

Show comment
Hide comment
@Calvinp

Calvinp Jan 26, 2016

Contributor

I am/will look into it.
Either way, this PR can be advanced separately from that. It will fix the pain in a fair portion of cases on its own.

Contributor

Calvinp commented Jan 26, 2016

I am/will look into it.
Either way, this PR can be advanced separately from that. It will fix the pain in a fair portion of cases on its own.

Fixed default sort order again; this time it actually works. Also mad…
…e it easier to sort by things other than name

@tpetr tpetr modified the milestone: 0.4.9 Jan 27, 2016

@tpetr tpetr modified the milestones: 0.4.9, 0.4.10 Feb 2, 2016

ssalinas added a commit that referenced this pull request Feb 4, 2016

Merge pull request #860 from HubSpot/sort-order
Fix the sorting in the wrong order bug.

@ssalinas ssalinas merged commit 6202153 into master Feb 4, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssalinas ssalinas deleted the sort-order branch Feb 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment