Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sorting in the wrong order bug. #860

Merged
merged 2 commits into from Feb 4, 2016
Merged

Fix the sorting in the wrong order bug. #860

merged 2 commits into from Feb 4, 2016

Conversation

@Calvinp
Copy link
Contributor

Calvinp commented Jan 26, 2016

When more than 10 files were present in a task, the sort order became very wrong in Chrome. Manually overriding the sort order would cause files to jump around.
This fixes the wrong initial sort order. Unfortunately files will still jump around, but that can be avoided by not manually sorting the table.

…ng files, but that will only happen when you manually change the sort order or a new file is added.
@wsorenson
Copy link
Contributor

wsorenson commented Jan 26, 2016

Why do files still jump around?

@Calvinp
Copy link
Contributor Author

Calvinp commented Jan 26, 2016

The page refreshes fairly often (I think whenever it becomes in focus), so if you manually override the sort order it will refresh back to the default sort order.

@wsorenson
Copy link
Contributor

wsorenson commented Jan 26, 2016

  • Is there a way to pull the elements without refreshing the page and changing client interactions like sort order?
  • Is there a way to persist changes like sort order after refresh?

Curious if this is related to standard backbone issues and thus there should be a well-known workaround. I'd check with other FE resources.

@Calvinp
Copy link
Contributor Author

Calvinp commented Jan 26, 2016

I am/will look into it.
Either way, this PR can be advanced separately from that. It will fix the pain in a fair portion of cases on its own.

…e it easier to sort by things other than name
@tpetr tpetr modified the milestone: 0.4.9 Jan 27, 2016
@tpetr tpetr modified the milestones: 0.4.9, 0.4.10 Feb 2, 2016
ssalinas added a commit that referenced this pull request Feb 4, 2016
Fix the sorting in the wrong order bug.
@ssalinas ssalinas merged commit 6202153 into master Feb 4, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ssalinas ssalinas deleted the sort-order branch Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.