New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show deleted request message if not deleted #863

Merged
merged 1 commit into from Jan 28, 2016

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Jan 26, 2016

It only checks the last history event to see if it is deleted. In the case things might be out of order there, we shouldn't keep showing the deleted message if the request is actually still active

@tpetr tpetr modified the milestone: 0.4.9 Jan 27, 2016

ssalinas added a commit that referenced this pull request Jan 28, 2016

Merge pull request #863 from HubSpot/deleted_request_msg
Don't show deleted request message if not deleted

@ssalinas ssalinas merged commit 567116b into master Jan 28, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssalinas ssalinas deleted the deleted_request_msg branch Jan 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment