better handling of Docker timeouts #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new ProcessFailedException(String.format("Timed out trying to reach docker daemon after %s seconds", configuration.getDockerClientTimeLimitSeconds())); | ||
| dockerUtils.pull(task.getTaskInfo().getContainer().getDocker().getImage()); | ||
| } catch (DockerException e) { | ||
| throw new ProcessFailedException(String.format("Could not pull docker image due to error: %s", e)); |
There was a problem hiding this comment.
Don't add the exception to an error message, include the exception as a cause argument.
ssalinas
added a commit
that referenced
this pull request
Feb 8, 2016
better handling of Docker timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
@wsorenson this was my addition to #864
DockerUtilshas a single threadedExecutorService(we only need one call at a time right now anyways) that will execute each with a timeout. So, anything docker is not executed on the main thread that needs to keep going in order for the Executor to communicate with mesos.Also adds a default thread pool of 5 for the docker client. The initial client was meant for managing large numbers of containers concurrently, thus the limit of 100.