add a default bounce expiration

[ssalinas]

Don't allow a bounce that will go on forever. Defaults to 60 minutes and shows in the ui as:

[wsorenson]

This logic was changed

[ssalinas]

Thanks, I'll check against staging to see what changed

[wsorenson]

Ah, now that I look again - are we now saying it's impossible to have unlimited bounce?

If so, what will you do if someone enters a negative value for this configuration? Need to have validation on it or allow people to set it to 0/negative to indicate that they don't want to use this feature.

In which case, we'd only set actionId if there was a duration set.

[ssalinas]

Do you think we should still create an expiring object either way? One thing I realized in writing this is that if we don't create the expiring object, there isn't actually a way to cancel the bounce (without doing a janky pause/unpause)

[wsorenson]

Good point, maybe just setup the config to validate that this must be non-zero, positive, then it's not an issue. I think you can do that with annotations. Someone could set it really high.

[ssalinas]

Ok, reworked this a bit. Not reconstructing the object anymore, just getting the durationMillis slightly differently for bounces in SingularityExpiringUserActionPoller so we can use the default and added a @Min for the config value. Tweaked the UI to show default value as well if there isn't a duration present for bounce