Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to post task metadata to a task #879

Merged
merged 39 commits into from Apr 11, 2016
Merged

Conversation

@wsorenson
Copy link
Contributor

@wsorenson wsorenson commented Feb 4, 2016

No description provided.

@wsorenson
Copy link
Contributor Author

@wsorenson wsorenson commented Feb 4, 2016

Will need to add this to:

  • UI
  • Email messages

Open question of whether we should provide a en enum for type (less extensible) but more explicit for the UI.

Still need to delay task email & persistence so that post-task metadata can be sent.


WebExceptions.checkBadRequest(taskMetadata.getTaskId().equals(taskIdObj), "Task metadata taskId %s didn't match API path %s", taskMetadata.getTaskId(), taskId);

SingularityCreateResult result = taskManager.saveTaskMetadata(taskMetadata);

This comment has been minimized.

@ssalinas

ssalinas Feb 5, 2016
Member

If the task has already been persisted to history and removed from zk, we won't be able to update the task's metadata. Do we want to be able to?

This comment has been minimized.

@wsorenson

wsorenson Feb 5, 2016
Author Contributor

In the ideal world, sure, but I don't think it's realistic for now, which is why we're delaying task persistence for this case.

This comment has been minimized.

@ssalinas

ssalinas Feb 5, 2016
Member

Sounds good, just realized you mentioned that at the end of the other comment

@wsorenson wsorenson added the hs_staging label Feb 9, 2016
@tpetr tpetr modified the milestone: 0.4.12 Feb 23, 2016
@wsorenson wsorenson added the hs_qa label Mar 8, 2016
@ssalinas ssalinas force-pushed the add_task_diagnostic_state branch from 1b8fd56 to 088ea9a Mar 11, 2016
Calvinp added 4 commits Mar 11, 2016
The new compare statement is now on a line of its own
Fix the indentation on the functions that construct new metadata objects or task history objects and add them to lists to be passed on to the jade email template.
@Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Mar 23, 2016

The UI and email portions of this are complete and merged in here. From my perspective, this is good to push along.

@ssalinas ssalinas added the hs_stable label Mar 24, 2016
@ssalinas ssalinas modified the milestones: 0.5.0, 0.6.0 Apr 5, 2016
@ssalinas ssalinas merged commit a6285b4 into master Apr 11, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ssalinas ssalinas deleted the add_task_diagnostic_state branch Apr 11, 2016
@ssalinas ssalinas removed hs_qa labels Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.