Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to post task metadata to a task #879

Merged
merged 39 commits into from Apr 11, 2016
Merged

Conversation

wsorenson
Copy link
Contributor

No description provided.

@wsorenson
Copy link
Contributor Author

Will need to add this to:

  • UI
  • Email messages

Open question of whether we should provide a en enum for type (less extensible) but more explicit for the UI.

Still need to delay task email & persistence so that post-task metadata can be sent.


WebExceptions.checkBadRequest(taskMetadata.getTaskId().equals(taskIdObj), "Task metadata taskId %s didn't match API path %s", taskMetadata.getTaskId(), taskId);

SingularityCreateResult result = taskManager.saveTaskMetadata(taskMetadata);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the task has already been persisted to history and removed from zk, we won't be able to update the task's metadata. Do we want to be able to?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the ideal world, sure, but I don't think it's realistic for now, which is why we're delaying task persistence for this case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, just realized you mentioned that at the end of the other comment

@tpetr tpetr modified the milestone: 0.4.12 Feb 23, 2016
@wsorenson wsorenson added the hs_qa label Mar 8, 2016
Calvin Pomerantz and others added 4 commits March 11, 2016 10:46
The new compare statement is now on a line of its own
Fix the indentation on the functions that construct new metadata objects or task history objects and add them to lists to be passed on to the jade email template.
@Calvinp
Copy link
Contributor

Calvinp commented Mar 23, 2016

The UI and email portions of this are complete and merged in here. From my perspective, this is good to push along.

@ssalinas ssalinas modified the milestones: 0.5.0, 0.6.0 Apr 5, 2016
@ssalinas ssalinas merged commit a6285b4 into master Apr 11, 2016
@ssalinas ssalinas deleted the add_task_diagnostic_state branch April 11, 2016 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants