GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No description provided.
Add ability to post task metadata to a task
Will need to add this to:
Open question of whether we should provide a en enum for type (less extensible) but more explicit for the UI.
Still need to delay task email & persistence so that post-task metadata can be sent.
If the task has already been persisted to history and removed from zk, we won't be able to update the task's metadata. Do we want to be able to?
In the ideal world, sure, but I don't think it's realistic for now, which is why we're delaying task persistence for this case.
Sounds good, just realized you mentioned that at the end of the other comment
Merge branch 'master' into add_task_diagnostic_state
Merge branch 'hedge_against_zk_tx' into add_task_diagnostic_state
add buffer to task persistence
add a queue for sending task finished mails (WIP)
actually send mails
make find bugs happy
check rate limit before queueing mail in ZK
change to use an API object
refactor config, allow mail to send immediately if metadata type is a…
fix test due to default config change
Add check that task still resides in ZK.
Merge branch 'add_task_diagnostic_state' of github.com:HubSpot/Singul…
…arity into add_task_diagnostic_state
Draft UI And Email template for Task Metadata.
Add 'level' field to TaskMetadata with options 'INFO', 'WARN' and 'ER…
Task metadata levels implemented in the UI and emails
The new compare statement is now on a line of its own
Fix the indentation on the functions that construct new metadata objects or task history objects and add them to lists to be passed on to the jade email template.
Merge branch 'master' into add_task_diagnostic_state_ui
Humanize timestamp is a helper function to fix compiler error caused …
…by newer version of master
Merge branch 'die-brunch' into linkify_text_in_p_tags
Importing linkify would be completely different with brunch compared to gulp
Merge remote-tracking branch 'origin/die-brunch' into add_task_diagno…
linkify text in p tags
Merge branch 'master' into linkify_text_in_p_tags
Merge branch 'add_task_diagnostic_state_ui' into linkify_text_in_p_tags
Linkify items with a linkify class instead of all p tags
Fix stray '-' that was preventing task email from sending when it had…
… metadata with a user
Merge branch 'linkify_text_in_p_tags' into add_task_diagnostic_state_ui
The UI and email portions of this are complete and merged in here. From my perspective, this is good to push along.
Better metadata templating in emails
Render metadata message in a pre to ensure it formats well
fix merge conflicts with master