Add ability to post task metadata to a task #879
Conversation
|
Will need to add this to:
Open question of whether we should provide a en enum for type (less extensible) but more explicit for the UI. Still need to delay task email & persistence so that post-task metadata can be sent. |
|
|
||
| WebExceptions.checkBadRequest(taskMetadata.getTaskId().equals(taskIdObj), "Task metadata taskId %s didn't match API path %s", taskMetadata.getTaskId(), taskId); | ||
|
|
||
| SingularityCreateResult result = taskManager.saveTaskMetadata(taskMetadata); |
There was a problem hiding this comment.
If the task has already been persisted to history and removed from zk, we won't be able to update the task's metadata. Do we want to be able to?
There was a problem hiding this comment.
In the ideal world, sure, but I don't think it's realistic for now, which is why we're delaying task persistence for this case.
There was a problem hiding this comment.
Sounds good, just realized you mentioned that at the end of the other comment
…arity into add_task_diagnostic_state
ssalinas
force-pushed
the
add_task_diagnostic_state
branch
from
1b8fd56 to
088ea9a
Compare
The new compare statement is now on a line of its own
Fix the indentation on the functions that construct new metadata objects or task history objects and add them to lists to be passed on to the jade email template.
…by newer version of master
Importing linkify would be completely different with brunch compared to gulp
… metadata with a user
|
The UI and email portions of this are complete and merged in here. From my perspective, this is good to push along. |
No description provided.