Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow deploy to specify port index for healthchecks and LB api #887

Merged
merged 3 commits into from Feb 10, 2016

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Feb 9, 2016

On the deploy you can specify loadBalancerPortIndex or healthcheckPortIndex (e.g. 0 for first allocated port, 1 for second allocated port). Defaults to 0 if not specified

/fixes #886

@@ -281,6 +289,11 @@ public String getId() {
return healthcheckTimeoutSeconds;
}

@ApiModelProperty(required=false, value="Perform healthcheck on this dynamically allocated port (e.g. 0 for first port)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably indicate that it defaults to the first port

@tpetr
Copy link
Contributor

tpetr commented Feb 9, 2016

Can you also add checks for these new fields to SingularityValidator.checkDeploy()?

@tpetr
Copy link
Contributor

tpetr commented Feb 9, 2016

Worth adding and/or updating tests to verify this works

@tpetr
Copy link
Contributor

tpetr commented Feb 9, 2016

(LGTM once all this is addressed)

@ssalinas
Copy link
Member Author

ssalinas commented Feb 9, 2016

Added validator pieces, just need to add tests

@tpetr
Copy link
Contributor

tpetr commented Feb 9, 2016

LGTM, thanks

tpetr pushed a commit that referenced this pull request Feb 10, 2016
allow deploy to specify port index for healthchecks and LB api
@tpetr tpetr merged commit 4468c7d into master Feb 10, 2016
@tpetr tpetr removed hs_qa labels Feb 10, 2016
@ssalinas ssalinas added this to the 0.4.10 milestone Mar 2, 2016
@ssalinas ssalinas deleted the port_indices branch Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support load balancing and healthchecks on other ports
2 participants