allow deploy to specify port index for healthchecks and LB api #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -281,6 +289,11 @@ public String getId() { | |||
| return healthcheckTimeoutSeconds; | |||
| } | |||
|
|
|||
| @ApiModelProperty(required=false, value="Perform healthcheck on this dynamically allocated port (e.g. 0 for first port)") | |||
There was a problem hiding this comment.
should probably indicate that it defaults to the first port
|
Can you also add checks for these new fields to |
|
Worth adding and/or updating tests to verify this works |
|
(LGTM once all this is addressed) |
|
Added validator pieces, just need to add tests |
ssalinas
force-pushed
the
port_indices
branch
from
c6ee903
to
fb56d10
Compare
|
LGTM, thanks |
tpetr
pushed a commit
that referenced
this pull request
Feb 10, 2016
allow deploy to specify port index for healthchecks and LB api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the deploy you can specify
loadBalancerPortIndexorhealthcheckPortIndex(e.g.0for first allocated port,1for second allocated port). Defaults to 0 if not specified/fixes #886