add support for max numbers of objects in ZK when no database is configured #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpetr
changed the title
tpetr
force-pushed
the
max-tasks-no-zk
branch
from
609d708
to
a34ca3d
Compare
| } | ||
| for (Collection<SingularityDeployHistory> deployHistoryForRequest : deployHistoryByRequestId.asMap().values()) { | ||
| int i=0; | ||
| for (SingularityDeployHistory deployHistory : deployHistoryForRequest) { |
There was a problem hiding this comment.
Do we need to sort the Collection<SingularityDeployHistory> first here? I saw where we were sorting for tasks and for requests, but did not see any sort for deploy history.
There was a problem hiding this comment.
The values in a TreeMultimap<> are sorted at insertion time
tpetr
pushed a commit
that referenced
this pull request
Feb 16, 2016
add support for max numbers of objects in ZK when no database is configured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #874