Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for max numbers of objects in ZK when no database is configured #889

Merged
merged 10 commits into from Feb 16, 2016

Conversation

tpetr
Copy link
Contributor

@tpetr tpetr commented Feb 9, 2016

re: #874

@tpetr tpetr changed the title WIP: add support for max numbers of objects in ZK when no database is configured add support for max numbers of objects in ZK when no database is configured Feb 9, 2016
}
for (Collection<SingularityDeployHistory> deployHistoryForRequest : deployHistoryByRequestId.asMap().values()) {
int i=0;
for (SingularityDeployHistory deployHistory : deployHistoryForRequest) {
Copy link
Member

@ssalinas ssalinas Feb 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to sort the Collection<SingularityDeployHistory> first here? I saw where we were sorting for tasks and for requests, but did not see any sort for deploy history.

Copy link
Contributor Author

@tpetr tpetr Feb 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values in a TreeMultimap<> are sorted at insertion time

@tpetr tpetr added the hs_qa label Feb 12, 2016
@tpetr tpetr added this to the 0.4.10 milestone Feb 12, 2016
tpetr pushed a commit that referenced this issue Feb 16, 2016
add support for max numbers of objects in ZK when no database is configured
@tpetr tpetr merged commit 678e95e into master Feb 16, 2016
1 of 2 checks passed
@tpetr tpetr removed hs_qa labels Feb 16, 2016
@tpetr
Copy link
Contributor Author

tpetr commented Feb 16, 2016

FYI @stevenschlansker

@ssalinas ssalinas deleted the max-tasks-no-zk branch Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants