Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for max numbers of objects in ZK when no database is configured #889

Merged
merged 10 commits into from Feb 16, 2016

Conversation

@tpetr
Copy link
Member

tpetr commented Feb 9, 2016

re: #874

@tpetr tpetr changed the title WIP: add support for max numbers of objects in ZK when no database is configured add support for max numbers of objects in ZK when no database is configured Feb 9, 2016
@tpetr tpetr force-pushed the max-tasks-no-zk branch from 609d708 to a34ca3d Feb 10, 2016
@tpetr tpetr added the hs_staging label Feb 10, 2016
}
for (Collection<SingularityDeployHistory> deployHistoryForRequest : deployHistoryByRequestId.asMap().values()) {
int i=0;
for (SingularityDeployHistory deployHistory : deployHistoryForRequest) {

This comment has been minimized.

Copy link
@ssalinas

ssalinas Feb 11, 2016

Member

Do we need to sort the Collection<SingularityDeployHistory> first here? I saw where we were sorting for tasks and for requests, but did not see any sort for deploy history.

This comment has been minimized.

Copy link
@tpetr

tpetr Feb 11, 2016

Author Member

The values in a TreeMultimap<> are sorted at insertion time

@tpetr tpetr added the hs_qa label Feb 12, 2016
tpetr added 4 commits Feb 12, 2016
@tpetr tpetr added this to the 0.4.10 milestone Feb 12, 2016
@tpetr tpetr added the hs_stable label Feb 12, 2016
tpetr added a commit that referenced this pull request Feb 16, 2016
add support for max numbers of objects in ZK when no database is configured
@tpetr tpetr merged commit 678e95e into master Feb 16, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tpetr
Copy link
Member Author

tpetr commented Feb 16, 2016

@ssalinas ssalinas deleted the max-tasks-no-zk branch Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.