add support for max numbers of objects in ZK when no database is configured #889

Merged
merged 10 commits into from Feb 16, 2016

Conversation

Projects
None yet
2 participants
@tpetr
Member

tpetr commented Feb 9, 2016

re: #874

@tpetr tpetr changed the title from WIP: add support for max numbers of objects in ZK when no database is configured to add support for max numbers of objects in ZK when no database is configured Feb 9, 2016

@tpetr tpetr added the hs_staging label Feb 10, 2016

- }
+ for (Collection<SingularityDeployHistory> deployHistoryForRequest : deployHistoryByRequestId.asMap().values()) {
+ int i=0;
+ for (SingularityDeployHistory deployHistory : deployHistoryForRequest) {

This comment has been minimized.

@ssalinas

ssalinas Feb 11, 2016

Member

Do we need to sort the Collection<SingularityDeployHistory> first here? I saw where we were sorting for tasks and for requests, but did not see any sort for deploy history.

@ssalinas

ssalinas Feb 11, 2016

Member

Do we need to sort the Collection<SingularityDeployHistory> first here? I saw where we were sorting for tasks and for requests, but did not see any sort for deploy history.

This comment has been minimized.

@tpetr

tpetr Feb 11, 2016

Member

The values in a TreeMultimap<> are sorted at insertion time

@tpetr

tpetr Feb 11, 2016

Member

The values in a TreeMultimap<> are sorted at insertion time

@tpetr tpetr added the hs_qa label Feb 12, 2016

tpetr added some commits Feb 12, 2016

@tpetr tpetr added this to the 0.4.10 milestone Feb 12, 2016

@tpetr tpetr added the hs_stable label Feb 12, 2016

tpetr added a commit that referenced this pull request Feb 16, 2016

Merge pull request #889 from HubSpot/max-tasks-no-zk
add support for max numbers of objects in ZK when no database is configured

@tpetr tpetr merged commit 678e95e into master Feb 16, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tpetr

This comment has been minimized.

Show comment
Hide comment
Member

tpetr commented Feb 16, 2016

@ssalinas ssalinas deleted the max-tasks-no-zk branch Apr 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment