Task Search UI #890
Merged
Task Search UI #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
January 28, 2016 12:54
…e that maybe should be held by the TaskSearch page instead
…k to the form page. Yay! Also some code organizational changes.
…k to the form page. Yay! Also some code organizational changes. And added files that weren't in the previous commit by accident
…ng TaskSearch search form
…change parameters, ability to jump to page
…lect number of tasks to show per page
| base += 'page=' + @page | ||
| anyParams = true | ||
| return '' if not anyParams | ||
| return base |
There was a problem hiding this comment.
We can build the params a bit cleaner here. Probably easier to build up an array of params (i.e. if @Attribute then add to array), then return paramsArray.join('&')
There was a problem hiding this comment.
an even better solution would be to build an Object of all the query params to set, and then use $.param() to convert the object into a legit query string
…n loading and no tasks found
… message isn't provided
…nto search-tasks-react
…urrent page is the last page
…arch button has not been pressed
…Results collections into HistoricalTasks
Refactor HistoricalTasks Collections into One
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Implements the UI for the new global and request task search APIs.
It is written in React, which has only been used for one other Singularity component (the aggregate log tailer).
It allows viewing up to 50 tasks per page, clearing search parameters, modifying search order, paging through search options, and returning to request.
It also includes some components, in a 'common' folder, that may be useful for others using react later on.