Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Search UI #890

Merged
merged 97 commits into from Mar 14, 2016
Merged

Task Search UI #890

merged 97 commits into from Mar 14, 2016

Conversation

@Calvinp
Copy link
Contributor

Calvinp commented Feb 9, 2016

This Implements the UI for the new global and request task search APIs.
It is written in React, which has only been used for one other Singularity component (the aggregate log tailer).
It allows viewing up to 50 tasks per page, clearing search parameters, modifying search order, paging through search options, and returning to request.
It also includes some components, in a 'common' folder, that may be useful for others using react later on.

Calvinp added 29 commits Jan 28, 2016
…e that maybe should be held by the TaskSearch page instead
…k to the form page. Yay! Also some code organizational changes.
…k to the form page. Yay! Also some code organizational changes. And added files that weren't in the previous commit by accident
…ng TaskSearch search form
…change parameters, ability to jump to page
…lect number of tasks to show per page
base += 'page=' + @page
anyParams = true
return '' if not anyParams
return base

This comment has been minimized.

Copy link
@ssalinas

ssalinas Feb 9, 2016

Member

We can build the params a bit cleaner here. Probably easier to build up an array of params (i.e. if @Attribute then add to array), then return paramsArray.join('&')

This comment has been minimized.

Copy link
@tpetr

tpetr Feb 9, 2016

Member

an even better solution would be to build an Object of all the query params to set, and then use $.param() to convert the object into a legit query string

This comment has been minimized.

Copy link
@ssalinas

ssalinas Feb 9, 2016

Member

TIL... thanks @tpetr 😃

@ssalinas ssalinas added the hs_qa label Feb 26, 2016
Calvinp and others added 11 commits Feb 29, 2016
…arch button has not been pressed
…Results collections into HistoricalTasks
Refactor HistoricalTasks Collections into One
ssalinas added a commit that referenced this pull request Mar 14, 2016
Task Search UI
@ssalinas ssalinas merged commit 31ca810 into task_search Mar 14, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ssalinas ssalinas deleted the search-tasks-react branch Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.