Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pushState for log line links #891

Merged
merged 17 commits into from Feb 29, 2016
Merged

use pushState for log line links #891

merged 17 commits into from Feb 29, 2016

Conversation

tpetr
Copy link
Contributor

@tpetr tpetr commented Feb 10, 2016

no longer opens a new tab when you click on a permalink to a log line

@tpetr tpetr added this to the 0.4.10 milestone Feb 10, 2016
@@ -105,7 +105,7 @@ class Router extends Backbone.Router
app.bootstrapController new DeployDetailController {requestId, deployId}

aggregateTail: (requestId, path = '') ->
offset = window.location.hash.substr(1) || null
offset = parseInt(window.location.hash.substr(1)) || null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should pass a radix to parseInt to make sure its always parsed the same parseInt(window.location.hash.substr(1),10)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done

@tpetr tpetr modified the milestones: 0.4.10, 0.4.11 Feb 18, 2016
@ssalinas ssalinas modified the milestones: 0.4.11, 0.4.12 Feb 23, 2016
@tpetr tpetr removed the hs_stable label Feb 23, 2016
tpetr pushed a commit that referenced this pull request Feb 29, 2016
use pushState for log line links
@tpetr tpetr merged commit cf16904 into master Feb 29, 2016
@tpetr tpetr removed hs_qa labels Feb 29, 2016
@ssalinas ssalinas deleted the tweak-logline-link branch April 5, 2016 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants