use pushState for log line links #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,7 +105,7 @@ class Router extends Backbone.Router | |||
| app.bootstrapController new DeployDetailController {requestId, deployId} | |||
|
|
|||
| aggregateTail: (requestId, path = '') -> | |||
| offset = window.location.hash.substr(1) || null | |||
| offset = parseInt(window.location.hash.substr(1)) || null | |||
There was a problem hiding this comment.
Should pass a radix to parseInt to make sure its always parsed the same parseInt(window.location.hash.substr(1),10)
added 2 commits
February 10, 2016 08:36
added 6 commits
February 19, 2016 10:49
tpetr
pushed a commit
that referenced
this pull request
Feb 29, 2016
use pushState for log line links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no longer opens a new tab when you click on a permalink to a log line