New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task kill checkbox label #894

Merged
merged 3 commits into from Feb 23, 2016

Conversation

Projects
None yet
3 participants
@Calvinp
Contributor

Calvinp commented Feb 12, 2016

The message for when you killed a task was not a label, so could not be clicked to select the corresponding checkbox.
On bounce, the label that should have been for incremental bounce = false was applying to incremental bounce = true.
This fixes both of those bugs.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Feb 16, 2016

Member

LGTM

Member

ssalinas commented Feb 16, 2016

LGTM

@Calvinp Calvinp added the hs_staging label Feb 18, 2016

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Feb 18, 2016

Member

LGTM

Member

tpetr commented Feb 18, 2016

LGTM

ssalinas added a commit that referenced this pull request Feb 23, 2016

@ssalinas ssalinas merged commit 96469bb into master Feb 23, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the task_kill_checkbox_label branch Feb 23, 2016

@tpetr tpetr modified the milestone: 0.4.12 Feb 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment