Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure run once tasks don't get launched at startup #903

Merged
merged 2 commits into from Feb 23, 2016
Merged

Conversation

@tpetr
Copy link
Member

tpetr commented Feb 17, 2016

  • Update SingularityStartup logic to ignore both ON_DEMAND and RUN_ONCE requests.
  • Add unit test to assert that RUN_ONCE requests aren't launched at startup
@@ -206,7 +206,7 @@ public boolean isAlwaysRunning() {

@JsonIgnore
public boolean isOneOff() {
return requestType == RequestType.ON_DEMAND;
return requestType == RequestType.ON_DEMAND || requestType == RequestType.RUN_ONCE;

This comment has been minimized.

Copy link
@tpetr

tpetr Feb 17, 2016

Author Member

@wsorenson do you agree with this approach, or would you rather I update the check in SingularityStartup?

@tpetr tpetr added the hs_staging label Feb 17, 2016
@tpetr tpetr added this to the 0.4.10 milestone Feb 17, 2016
@tpetr tpetr modified the milestones: 0.4.10, 0.4.11 Feb 18, 2016
@ssalinas ssalinas modified the milestones: 0.4.11, 0.4.12 Feb 23, 2016
tpetr added a commit that referenced this pull request Feb 23, 2016
ensure run once tasks don't get launched at startup
@tpetr tpetr merged commit a9d74b8 into master Feb 23, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the dont-autostart-run-once branch Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.