Fuzzy sort better adjusted score #908

Merged
merged 5 commits into from Feb 22, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Feb 19, 2016

Requests and tasks that were searched from the requests (or tasks) page would sometimes filter to the bottom of search results despite containing the search term. This is because the fuzzy search algorithm only favored requests that started with the term (and not even that for tasks).
This fixes that, giving the highest score to requests or tasks that start with the search term, a medium score to requests or tasks that contain the search term, and a low score to others.

Calvinp added some commits Feb 19, 2016

Add score adjustment to fuzzy search in tasks, with high priority for…
… tasks that start with the search term, medium for tasks that contain the search term, and low for tasks that don't contain the search term
@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Feb 19, 2016

Member

logic looks good. Now that this is replicated in two places, can we move the score adjusting logic maybe into utils.coffee? Then we just have one place to update if we want to change it

Member

ssalinas commented Feb 19, 2016

logic looks good. Now that this is replicated in two places, can we move the score adjusting logic maybe into utils.coffee? Then we just have one place to update if we want to change it

@Calvinp

This comment has been minimized.

Show comment
Hide comment
@Calvinp

Calvinp Feb 19, 2016

Contributor

The score adjusting logic is moved into utils.

Contributor

Calvinp commented Feb 19, 2016

The score adjusting logic is moved into utils.

@Calvinp Calvinp added the hs_stable label Feb 19, 2016

ssalinas added a commit that referenced this pull request Feb 22, 2016

@ssalinas ssalinas merged commit c09b4d3 into master Feb 22, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the fuzzy_sort_better_adjustedScore branch Feb 22, 2016

@ssalinas ssalinas added this to the 0.4.11 milestone Feb 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment