Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic framework auth #910

Merged
merged 3 commits into from Feb 23, 2016
Merged

basic framework auth #910

merged 3 commits into from Feb 23, 2016

Conversation

ssalinas
Copy link
Member

/fixes #909

@tpetr seemed almost too simple, does this look right to you?

@jhaber
Copy link
Member

jhaber commented Feb 19, 2016

CharSet on the getBytes call?

@ssalinas
Copy link
Member Author

Good call @jhaber thanks, fixed now

if (configuration.getCredentialPrincipal().isPresent() && configuration.getCredentialSecret().isPresent()) {
Credential credential = Credential.newBuilder()
.setPrincipal(configuration.getCredentialPrincipal().get())
.setSecret(ByteString.copyFrom(configuration.getCredentialSecret().get().getBytes("UTF-8")))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: for Java 7+ StandardCharsets.UTF_8 is preferred

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

ssalinas added a commit that referenced this pull request Feb 23, 2016
@ssalinas ssalinas merged commit 883d084 into master Feb 23, 2016
@ssalinas ssalinas deleted the framework_auth branch February 23, 2016 17:51
@tpetr tpetr modified the milestone: 0.4.12 Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Framework Authentication
3 participants