New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic framework auth #910

Merged
merged 3 commits into from Feb 23, 2016

Conversation

Projects
None yet
3 participants
@ssalinas
Member

ssalinas commented Feb 19, 2016

/fixes #909

@tpetr seemed almost too simple, does this look right to you?

@jhaber

This comment has been minimized.

Show comment
Hide comment
@jhaber

jhaber Feb 19, 2016

Member

CharSet on the getBytes call?

Member

jhaber commented Feb 19, 2016

CharSet on the getBytes call?

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Feb 19, 2016

Member

Good call @jhaber thanks, fixed now

Member

ssalinas commented Feb 19, 2016

Good call @jhaber thanks, fixed now

Show outdated Hide outdated ...rvice/src/main/java/com/hubspot/singularity/mesos/SingularityDriver.java
if (configuration.getCredentialPrincipal().isPresent() && configuration.getCredentialSecret().isPresent()) {
Credential credential = Credential.newBuilder()
.setPrincipal(configuration.getCredentialPrincipal().get())
.setSecret(ByteString.copyFrom(configuration.getCredentialSecret().get().getBytes("UTF-8")))

This comment has been minimized.

@jhaber

jhaber Feb 19, 2016

Member

nitpick: for Java 7+ StandardCharsets.UTF_8 is preferred

@jhaber

jhaber Feb 19, 2016

Member

nitpick: for Java 7+ StandardCharsets.UTF_8 is preferred

This comment has been minimized.

@ssalinas

ssalinas Feb 19, 2016

Member

updated

@ssalinas

ssalinas Feb 19, 2016

Member

updated

ssalinas added a commit that referenced this pull request Feb 23, 2016

@ssalinas ssalinas merged commit 883d084 into master Feb 23, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssalinas ssalinas deleted the framework_auth branch Feb 23, 2016

@tpetr tpetr modified the milestone: 0.4.12 Feb 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment