add docs on request and deploy concepts#922
Merged
Merged
Conversation
Contributor
|
Could be good to get @markhazlewood's eyes on this too |
Contributor
|
I kind of have a nitpick with the first person tone (doesn't match the test of the docs), but beside that, LGTM |
Contributor
Author
|
Updated to sound more like the docs in |
649b24e to
df0c64f
Compare
|
|
||
|
|
||
| ### Creating a `Request` | ||
| You have a new web service called `TestService` that you want to run via Singularity. The first thing you need to do is create a `Request` for `TestService`. To create this request, you would `POST` json over http to the Singularity API or create a request via the new request page in the Singularity UI. Example json: |
Contributor
There was a problem hiding this comment.
may want to include the endpoint (.../api/requests) or a link to the API reference doc for creating the request
da5b96d to
dc68bb9
Compare
Contributor
|
LGTM |
ssalinas
added a commit
that referenced
this pull request
Feb 26, 2016
add docs on request and deploy concepts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tpetr