New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get memory info from deploy object instead of mesos task resources #925

Merged
merged 1 commit into from Mar 17, 2016

Conversation

Projects
None yet
2 participants
@tpetr
Member

tpetr commented Feb 29, 2016

#900 set a meaningful status message when a task dies from an OOM kill, but it depended on Mesos task data being available, which may not always be true (see #892). This PR grabs the allocated memory from the SingularityDeploy object instead.

@tpetr tpetr added this to the 0.4.12 milestone Feb 29, 2016

ssalinas added a commit that referenced this pull request Mar 17, 2016

Merge pull request #925 from HubSpot/mesos-oom2
get memory info from deploy object instead of mesos task resources

@ssalinas ssalinas merged commit 61a2baf into master Mar 17, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the mesos-oom2 branch Mar 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment