Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing an early return for numPorts == 0 #927

Merged
merged 1 commit into from Mar 8, 2016
Merged

Conversation

ssalinas
Copy link
Member

/fixes #926

Before I added support for literal port mappings we skipped this section entirely when numPorts was 0. Needed to add a check for it now that we can hit this code path with numPorts of 0.
/cc @tpetr

@tpetr tpetr added the hs_qa label Mar 4, 2016
@tpetr tpetr added this to the 0.4.12 milestone Mar 4, 2016
ssalinas added a commit that referenced this pull request Mar 8, 2016
missing an early return for numPorts == 0
@ssalinas ssalinas merged commit 8352690 into master Mar 8, 2016
@ssalinas ssalinas deleted the num_ports_fix branch March 8, 2016 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants