Skip to content

Don't display healthcheck message for tasks in state TASK_LOST or TASK_FINISHED #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Mar 4, 2016

Missed these potential task states - now if a task is lost or finishes before having a successful healthcheck, it will not give a misleading healthcheck message.

@ssalinas
Copy link
Member

ssalinas commented Mar 4, 2016

LGTM

ssalinas added a commit that referenced this pull request Mar 7, 2016
Don't display healthcheck message for tasks in state TASK_LOST or TASK_FINISHED
@ssalinas ssalinas merged commit c16a4f7 into failed_task_healthcheck_message Mar 7, 2016
@ssalinas ssalinas deleted the task_status_healthcheck_message branch March 7, 2016 14:34
@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants