Skip to content

Add ability to search through tasks table by request type#936

Merged
ssalinas merged 2 commits into
masterfrom
filter-tasks-based-on-request-type
Mar 17, 2016
Merged

Add ability to search through tasks table by request type#936
ssalinas merged 2 commits into
masterfrom
filter-tasks-based-on-request-type

Conversation

@Calvinp

@Calvinp Calvinp commented Mar 7, 2016

Copy link
Copy Markdown
Contributor

This will break bookmarks and other URLs into the task table.

@ssalinas

ssalinas commented Mar 7, 2016

Copy link
Copy Markdown
Contributor

Now that we are using the requestsTable/requestsFilter template both in requests and in tasks, can we move it up a directory, and maybe rename it to requestTypeFilter.hbs? Bit more descriptive, and moves it out of a folder specific to requests since it's now shared. Other than that looks good

@Calvinp

Calvinp commented Mar 7, 2016

Copy link
Copy Markdown
Contributor Author

@ssalinas Done

@ssalinas

Copy link
Copy Markdown
Contributor

LGTM

ssalinas added a commit that referenced this pull request Mar 17, 2016
Add ability to search through tasks table by request type
@ssalinas ssalinas merged commit aadb9ad into master Mar 17, 2016
@ssalinas ssalinas deleted the filter-tasks-based-on-request-type branch March 17, 2016 13:55
@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants