New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to search through tasks table by request type #936

Merged
merged 2 commits into from Mar 17, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Mar 7, 2016

This will break bookmarks and other URLs into the task table.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Mar 7, 2016

Member

Now that we are using the requestsTable/requestsFilter template both in requests and in tasks, can we move it up a directory, and maybe rename it to requestTypeFilter.hbs? Bit more descriptive, and moves it out of a folder specific to requests since it's now shared. Other than that looks good

Member

ssalinas commented Mar 7, 2016

Now that we are using the requestsTable/requestsFilter template both in requests and in tasks, can we move it up a directory, and maybe rename it to requestTypeFilter.hbs? Bit more descriptive, and moves it out of a folder specific to requests since it's now shared. Other than that looks good

@Calvinp

This comment has been minimized.

Show comment
Hide comment
@Calvinp

Calvinp Mar 7, 2016

Contributor

@ssalinas Done

Contributor

Calvinp commented Mar 7, 2016

@ssalinas Done

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Mar 17, 2016

Member

LGTM

Member

ssalinas commented Mar 17, 2016

LGTM

ssalinas added a commit that referenced this pull request Mar 17, 2016

Merge pull request #936 from HubSpot/filter-tasks-based-on-request-type
Add ability to search through tasks table by request type

@ssalinas ssalinas merged commit aadb9ad into master Mar 17, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the filter-tasks-based-on-request-type branch Mar 17, 2016

@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment