Refactor HistoricalTasks Collections into One #937

Merged
merged 1 commit into from Mar 14, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Mar 7, 2016

The RequestHistoricalTasks, DeployHistoricalTasks and TaskSearch collections were all almost exactly the same (except they hit slightly different endpoints). This refactors them to actually be the same collection.

Refactor RequestHistoricalTasks, DeployHistoricalTasks and TaskSearch…
…Results collections into HistoricalTasks
- task.id = task.taskId.id
- data
-
- getTasksForDeploy: (deployId) ->

This comment has been minimized.

@ssalinas

ssalinas Mar 7, 2016

Member

didn't see it anywhere, but assuming this method is unused since you didn't reimplement it, is that correct?

@ssalinas

ssalinas Mar 7, 2016

Member

didn't see it anywhere, but assuming this method is unused since you didn't reimplement it, is that correct?

This comment has been minimized.

@Calvinp

Calvinp Mar 7, 2016

Contributor

Correct. I think anything that would use that were using the DeployHistoricalTasks collection.

And the endpoint to get historical tasks based on a deploy is seemingly unnecessary now that you can get those by using the Task Search endpoint and specifying a deploy id.

@Calvinp

Calvinp Mar 7, 2016

Contributor

Correct. I think anything that would use that were using the DeployHistoricalTasks collection.

And the endpoint to get historical tasks based on a deploy is seemingly unnecessary now that you can get those by using the Task Search endpoint and specifying a deploy id.

ssalinas added a commit that referenced this pull request Mar 14, 2016

Merge pull request #937 from HubSpot/merge-task-history-collections
Refactor HistoricalTasks Collections into One

@ssalinas ssalinas merged commit 7d30a46 into search-tasks-react Mar 14, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the merge-task-history-collections branch Mar 14, 2016

@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment