Refactor HistoricalTasks Collections into One #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Results collections into HistoricalTasks
| task.id = task.taskId.id | ||
| data | ||
|
|
||
| getTasksForDeploy: (deployId) -> |
There was a problem hiding this comment.
didn't see it anywhere, but assuming this method is unused since you didn't reimplement it, is that correct?
There was a problem hiding this comment.
Correct. I think anything that would use that were using the DeployHistoricalTasks collection.
And the endpoint to get historical tasks based on a deploy is seemingly unnecessary now that you can get those by using the Task Search endpoint and specifying a deploy id.
ssalinas
added a commit
that referenced
this pull request
Mar 14, 2016
Refactor HistoricalTasks Collections into One
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RequestHistoricalTasks, DeployHistoricalTasks and TaskSearch collections were all almost exactly the same (except they hit slightly different endpoints). This refactors them to actually be the same collection.