Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HistoricalTasks Collections into One #937

Merged
merged 1 commit into from Mar 14, 2016

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Mar 7, 2016

The RequestHistoricalTasks, DeployHistoricalTasks and TaskSearch collections were all almost exactly the same (except they hit slightly different endpoints). This refactors them to actually be the same collection.

task.id = task.taskId.id
data

getTasksForDeploy: (deployId) ->
Copy link
Member

@ssalinas ssalinas Mar 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't see it anywhere, but assuming this method is unused since you didn't reimplement it, is that correct?

Copy link
Contributor Author

@Calvinp Calvinp Mar 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I think anything that would use that were using the DeployHistoricalTasks collection.

And the endpoint to get historical tasks based on a deploy is seemingly unnecessary now that you can get those by using the Task Search endpoint and specifying a deploy id.

ssalinas added a commit that referenced this issue Mar 14, 2016
Refactor HistoricalTasks Collections into One
@ssalinas ssalinas merged commit 7d30a46 into search-tasks-react Mar 14, 2016
2 checks passed
@ssalinas ssalinas deleted the merge-task-history-collections branch Mar 14, 2016
@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants